Re: pgsql: More message style fixes

2019-05-16 Thread Michael Paquier
On Thu, May 16, 2019 at 10:29:16PM -0400, Alvaro Herrera wrote: > Argh. Apologies, sorry for fixing so quickly. No problem. The buildfarm does not complain anymore after the patch, so it looks that we are good. -- Michael signature.asc Description: PGP signature

Re: pgsql: More message style fixes

2019-05-16 Thread Alvaro Herrera
On 2019-May-17, Michael Paquier wrote: > On Thu, May 16, 2019 at 07:20:38PM -0400, Tom Lane wrote: > > Alvaro Herrera writes: > >> More message style fixes > > > > The buildfarm thinks you forgot something. > > One contrib module is impacted, citext, because it uses regexes and it > has multipl

Re: pgsql: More message style fixes

2019-05-16 Thread Michael Paquier
On Thu, May 16, 2019 at 08:22:25PM -0400, Tom Lane wrote: > Looks reasonable, but check if any of the other tests have alternative > expected-files that you need to fix too. I am not noticing anything else. And I have checked once before sending the previous patch, and once again now. If I have

Re: pgsql: More message style fixes

2019-05-16 Thread Tom Lane
Michael Paquier writes: > On Thu, May 16, 2019 at 07:20:38PM -0400, Tom Lane wrote: >> The buildfarm thinks you forgot something. > One contrib module is impacted, citext, because it uses regexes and it > has multiple expected outputs. The attached brings back my build to > green. Thoughts? Lo

Re: pgsql: More message style fixes

2019-05-16 Thread Michael Paquier
On Thu, May 16, 2019 at 07:20:38PM -0400, Tom Lane wrote: > Alvaro Herrera writes: >> More message style fixes > > The buildfarm thinks you forgot something. One contrib module is impacted, citext, because it uses regexes and it has multiple expected outputs. The attached brings back my build t

Re: pgsql: More message style fixes

2019-05-16 Thread Tom Lane
Alvaro Herrera writes: > More message style fixes The buildfarm thinks you forgot something. regards, tom lane