On Thu, Sep 18, 2025 at 09:56:44AM -0500, Nathan Bossart wrote:
> Thanks for reviewing. Committed.
Thanks. batta looks happy now.
--
Michael
signature.asc
Description: PGP signature
On Thu, Sep 18, 2025 at 08:49:20AM +0900, Michael Paquier wrote:
> Anyway, your comment additions in v3 look fine from here.
Thanks for reviewing. Committed.
--
nathan
On Wed, Sep 17, 2025 at 09:34:24AM -0500, Nathan Bossart wrote:
> Yeah, this stuff is rather precarious, and I'm a bit surprised there
> haven't been more problems in this area.
LWLock handling is quite special, but I am also getting suspicious
about some more shmem areas. Perhaps these deserve a
On Wed, Sep 17, 2025 at 01:47:19PM +0900, Michael Paquier wrote:
> Perhaps LocalNamedLWLockTrancheRequestArray should be initialized to
> NULL when declared, and I'd rather document the reasons behind what
> this patch is doing in LWLockShmemSize() and when the state is
> initialized in CreateLWLoc
On Tue, Sep 16, 2025 at 11:10:34PM -0500, Nathan Bossart wrote:
> I was able to simplify the patch.
+ if (LocalNamedLWLockTrancheRequestArray)
+ NamedLWLockTrancheRequestArray = LocalNamedLWLockTrancheRequestArray;
It's not a common practice in the code to rely on a shmem state that
shoul
On Tue, Sep 16, 2025 at 10:27:34PM -0500, Nathan Bossart wrote:
> It looks like the postmaster is trying to access the request array after
> re-initializing shared memory, which of course fails. So, we need to keep
> the request array in postmaster's local memory, too. Attached is a quick
> attem
On Wed, Sep 17, 2025 at 11:35:56AM +0900, Michael Paquier wrote:
> Since this commit has been merged, batta has kept failing. Here is
> the first failure:
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=batta&dt=2025-09-12%2002%3A05%3A01
Thanks for bringing this to my attention.
> And
Ni Nathan,
On Thu, Sep 11, 2025 at 09:15:12PM +, Nathan Bossart wrote:
> Move named LWLock tranche requests to shared memory.
>
> In EXEC_BACKEND builds, GetNamedLWLockTranche() can segfault when
> called outside of the postmaster process, as it might access
> NamedLWLockTrancheRequestArray,
