Re: pgsql: Redesign initialization of partition routing structures

2018-11-16 Thread Alvaro Herrera
Hello On 2018-Nov-16, Andres Freund wrote: > On 2018-11-16 16:54:03 -0300, Alvaro Herrera wrote: > > Thanks, I just noticed it and will push this in a minute. Since I > > cannot reproduce the error, it's a blind fix, but seems correct. > > FWIW, if you use clang you can probably reproduce this

Re: pgsql: Redesign initialization of partition routing structures

2018-11-16 Thread Andres Freund
Hi, On 2018-11-16 16:54:03 -0300, Alvaro Herrera wrote: > Thanks, I just noticed it and will push this in a minute. Since I > cannot reproduce the error, it's a blind fix, but seems correct. FWIW, if you use clang you can probably reproduce this using -Werror=typedef-redefinition Greetings, An

Re: pgsql: Redesign initialization of partition routing structures

2018-11-16 Thread Alvaro Herrera
On 2018-Nov-16, Tom Lane wrote: > Alvaro Herrera writes: > > Redesign initialization of partition routing structures > > Some of the buildfarm doesn't like this: > > ccache gcc -std=c99 -Wall -Wmissing-prototypes -Wpointer-arith > -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-a

Re: pgsql: Redesign initialization of partition routing structures

2018-11-16 Thread Tom Lane
Alvaro Herrera writes: > Redesign initialization of partition routing structures Some of the buildfarm doesn't like this: ccache gcc -std=c99 -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasin