Re: pgsql: Remove the adminpack contrib extension

2024-03-04 Thread Tom Lane
Daniel Gustafsson writes: > The deviation between database names on crake found in the follow-up commit is > a bit concerning. Too much magic hidden away from the codetree makes it hard > to get tests right on the first try. Yeah, I didn't understand that at all. I have a non-reporting buildfar

Re: pgsql: Remove the adminpack contrib extension

2024-03-04 Thread Daniel Gustafsson
> On 4 Mar 2024, at 17:34, Tom Lane wrote: > > Daniel Gustafsson writes: >> I see that my fix didn't solve it for 11 and 9.x on crake and drongo, will >> rebuild more old trees and test to find the correct fix. > > The oldest branches didn't make that DB, so you need an "IF EXISTS". > I pushed

Re: pgsql: Remove the adminpack contrib extension

2024-03-04 Thread Tom Lane
Daniel Gustafsson writes: > I see that my fix didn't solve it for 11 and 9.x on crake and drongo, will > rebuild more old trees and test to find the correct fix. The oldest branches didn't make that DB, so you need an "IF EXISTS". I pushed a fix after quickly checking it here.

Re: pgsql: Remove the adminpack contrib extension

2024-03-04 Thread Daniel Gustafsson
> On 4 Mar 2024, at 16:27, Alvaro Herrera wrote: > > On 2024-Mar-04, Daniel Gustafsson wrote: > >> The pg_upgrade Xversion test on crake failed on this, I'm trying to reproduce >> the cross-version test locally to verify the below diff but it's right now >> failing on an unrelated thing. > > Wh

Re: pgsql: Remove the adminpack contrib extension

2024-03-04 Thread Alvaro Herrera
On 2024-Mar-04, Daniel Gustafsson wrote: > The pg_upgrade Xversion test on crake failed on this, I'm trying to reproduce > the cross-version test locally to verify the below diff but it's right now > failing on an unrelated thing. What unrelated thing? I suggest to try to initdb the old version

Re: pgsql: Remove the adminpack contrib extension

2024-03-04 Thread Daniel Gustafsson
> On 4 Mar 2024, at 12:43, Daniel Gustafsson wrote: > > Remove the adminpack contrib extension The pg_upgrade Xversion test on crake failed on this, I'm trying to reproduce the cross-version test locally to verify the below diff but it's right now failing on an unrelated thing. If anyone has a