Re: pgsql: Remove unnecessary casts in free() and pfree()

2022-08-27 Thread Tom Lane
I wrote: > Justin Pryzby writes: >> This seems to be breaking cfbot's "warnings" test. > Hmm, well, casting away const is certainly not within pfree's remit, > so I'm glad we changed this. Oh, I see: sepgsql's quote_object_name() is doing const char *temp; temp = quote_identifi

Re: pgsql: Remove unnecessary casts in free() and pfree()

2022-08-27 Thread Tom Lane
Justin Pryzby writes: > On Fri, Aug 26, 2022 at 02:02:33PM +, Peter Eisentraut wrote: >> Remove unnecessary casts in free() and pfree() > This seems to be breaking cfbot's "warnings" test. > [07:49:48.983] label.c:665:10: error: passing argument 1 of ‘pfree’ discards > ‘const’ qualifier fro

Re: pgsql: Remove unnecessary casts in free() and pfree()

2022-08-27 Thread Justin Pryzby
On Fri, Aug 26, 2022 at 02:02:33PM +, Peter Eisentraut wrote: > Remove unnecessary casts in free() and pfree() This seems to be breaking cfbot's "warnings" test. [07:49:48.983] label.c:665:10: error: passing argument 1 of ‘pfree’ discards ‘const’ qualifier from pointer target type [-Werror=d