Re: pgsql: Restrict accesses to non-system views and foreign tables during

2024-08-29 Thread Masahiko Sawada
On Thu, Aug 29, 2024 at 7:29 AM Peter Eisentraut wrote: > > On 27.08.24 22:02, Masahiko Sawada wrote: > > On Tue, Aug 27, 2024 at 6:29 AM Tom Lane wrote: > >> > >> Peter Eisentraut writes: > >>> Maybe in the documentation it would also be appropriate to mention that > >>> this is meant to be use

Re: pgsql: Restrict accesses to non-system views and foreign tables during

2024-08-29 Thread Peter Eisentraut
On 27.08.24 22:02, Masahiko Sawada wrote: On Tue, Aug 27, 2024 at 6:29 AM Tom Lane wrote: Peter Eisentraut writes: Maybe in the documentation it would also be appropriate to mention that this is meant to be used by pg_dump, not for general use -- unless it is? I'd vote against that. I thi

Re: pgsql: Restrict accesses to non-system views and foreign tables during

2024-08-27 Thread Masahiko Sawada
On Tue, Aug 27, 2024 at 6:29 AM Tom Lane wrote: > > Peter Eisentraut writes: > > Maybe in the documentation it would also be appropriate to mention that > > this is meant to be used by pg_dump, not for general use -- unless it is? > > I'd vote against that. I think other catalog-scanning tools m

Re: pgsql: Restrict accesses to non-system views and foreign tables during

2024-08-27 Thread Tom Lane
Peter Eisentraut writes: > Maybe in the documentation it would also be appropriate to mention that > this is meant to be used by pg_dump, not for general use -- unless it is? I'd vote against that. I think other catalog-scanning tools might like to use this too. regards

Re: pgsql: Restrict accesses to non-system views and foreign tables during

2024-08-27 Thread Peter Eisentraut
On 26.08.24 21:05, Masahiko Sawada wrote: Maybe using the word "prohibit" makes it a bit clear? For example, I think that would be much clearer, yes. In guc_tables.c: Prohibits access to non-system relations of specified kinds End with period. In doc: Set relation kinds of non-system rela

Re: pgsql: Restrict accesses to non-system views and foreign tables during

2024-08-26 Thread Masahiko Sawada
On Mon, Aug 26, 2024 at 7:14 AM Peter Eisentraut wrote: > > On 05.08.24 15:07, Masahiko Sawada wrote: > > To address this, pg_dump now utilizes the newly introduced > > restrict_nonsystem_relation_kind GUC parameter to restrict the > > accesses to non-system views and foreign tables during the dum

Re: pgsql: Restrict accesses to non-system views and foreign tables during

2024-08-26 Thread Peter Eisentraut
On 05.08.24 15:07, Masahiko Sawada wrote: To address this, pg_dump now utilizes the newly introduced restrict_nonsystem_relation_kind GUC parameter to restrict the accesses to non-system views and foreign tables during the dump process. This new GUC parameter is added to back branches too, but th