Re: pgsql: Rework the pg_statistic_ext catalog

2019-06-16 Thread Tomas Vondra
On Sun, Jun 16, 2019 at 01:52:03PM -0400, Tom Lane wrote: Fabien COELHO writes: This theory is insufficient to explain why Coelho's animals failed, though. Maybe it would, if you also posit a ccache screwup? But it's not obvious from their configurations that they're using ccache at all. I

Re: pgsql: Rework the pg_statistic_ext catalog

2019-06-16 Thread Tom Lane
Fabien COELHO writes: >> This theory is insufficient to explain why Coelho's animals failed, >> though. Maybe it would, if you also posit a ccache screwup? But it's >> not obvious from their configurations that they're using ccache at all. > Indeed, no ccache. The compilers change often (well,

Re: pgsql: Rework the pg_statistic_ext catalog

2019-06-16 Thread Fabien COELHO
Hello Tom, I see that Coelho's two bleeding-edge-clang animals are reporting that failure too. Normally I'd just ignore those two; And you'd be right. they break pretty regularly. Maybe you're using an almost-bleeding-edge clang? Oh --- I managed to reproduce that failure locally on RH

Re: pgsql: Rework the pg_statistic_ext catalog

2019-06-16 Thread Tom Lane
I wrote: > Tomas Vondra writes: >> OK, it seems the buildfarm is getting green again. I'm not sure why I'm >> seeing the failure in 011_crash_recovery.pl, while the buildfarm does >> not. Perhaps my environment is borked in some way? Not sure. > I see that Coelho's two bleeding-edge-clang animals

Re: pgsql: Rework the pg_statistic_ext catalog

2019-06-16 Thread Tom Lane
Tomas Vondra writes: > OK, it seems the buildfarm is getting green again. I'm not sure why I'm > seeing the failure in 011_crash_recovery.pl, while the buildfarm does > not. Perhaps my environment is borked in some way? Not sure. I see that Coelho's two bleeding-edge-clang animals are reporting t

Re: pgsql: Rework the pg_statistic_ext catalog

2019-06-16 Thread Tom Lane
Tomas Vondra writes: > Anyway, I'm wondering if we need the REVOKE/GRANT on pg_statistic_ext at > all, and if we do if we should just remove the list of columns, and > grant SELECT on all. All the sensitive columns were moved to another > catalog, after all. +1. Per-column permissions checks see

Re: pgsql: Rework the pg_statistic_ext catalog

2019-06-16 Thread Tomas Vondra
On Sun, Jun 16, 2019 at 12:03:28PM +0200, Tomas Vondra wrote: On Sun, Jun 16, 2019 at 10:56:51AM +0200, Tomas Vondra wrote: On Sun, Jun 16, 2019 at 07:18:58AM +0100, Dean Rasheed wrote: On Sun, 16 Jun 2019, 03:05 Tom Lane, wrote: I wrote: Tomas Vondra writes: Rework the pg_statistic_ext c

Re: pgsql: Rework the pg_statistic_ext catalog

2019-06-16 Thread Tomas Vondra
On Sun, Jun 16, 2019 at 10:56:51AM +0200, Tomas Vondra wrote: On Sun, Jun 16, 2019 at 07:18:58AM +0100, Dean Rasheed wrote: On Sun, 16 Jun 2019, 03:05 Tom Lane, wrote: I wrote: Tomas Vondra writes: Rework the pg_statistic_ext catalog So ... not one of the buildfarm members that are runn

Re: pgsql: Rework the pg_statistic_ext catalog

2019-06-16 Thread Tomas Vondra
On Sun, Jun 16, 2019 at 07:18:58AM +0100, Dean Rasheed wrote: On Sun, 16 Jun 2019, 03:05 Tom Lane, wrote: I wrote: > Tomas Vondra writes: >> Rework the pg_statistic_ext catalog > So ... not one of the buildfarm members that are running TAP tests > likes this. ... > I think probably what's ha

Re: pgsql: Rework the pg_statistic_ext catalog

2019-06-15 Thread Dean Rasheed
On Sun, 16 Jun 2019, 03:05 Tom Lane, wrote: > I wrote: > > Tomas Vondra writes: > >> Rework the pg_statistic_ext catalog > > > So ... not one of the buildfarm members that are running TAP tests > > likes this. ... > > I think probably what's happening is that pg_dump is still trying to dump > >

Re: pgsql: Rework the pg_statistic_ext catalog

2019-06-15 Thread Tom Lane
I wrote: > Tomas Vondra writes: >> Rework the pg_statistic_ext catalog > So ... not one of the buildfarm members that are running TAP tests > likes this. ... > I think probably what's happening is that pg_dump is still trying to dump > directly from the catalog, when what it needs to do now is du

Re: pgsql: Rework the pg_statistic_ext catalog

2019-06-15 Thread Tom Lane
Tomas Vondra writes: > Rework the pg_statistic_ext catalog So ... not one of the buildfarm members that are running TAP tests likes this. The failures look like # Running: pg_dump --no-sync --file=/Users/tgl/pgsql/src/bin/pg_dump/tmp_check/tmp_test_cSh8/role.sql --role=regress_dump_test_role