Re: pgsql: Transforms for jsonb to PL/Python

2018-04-02 Thread Tom Lane
Peter Eisentraut writes: > On 4/1/18 18:07, Tom Lane wrote: >> 1. Just remove the tests involving inf/nan. As far as I can see, >> there's no explicit handling of these cases in jsonb_plpython, >> so we're not really buying any test coverage of our own code anyway. > That makes sense. OK, done.

Re: pgsql: Transforms for jsonb to PL/Python

2018-04-02 Thread Peter Eisentraut
On 4/1/18 18:07, Tom Lane wrote: > 1. Just remove the tests involving inf/nan. As far as I can see, > there's no explicit handling of these cases in jsonb_plpython, > so we're not really buying any test coverage of our own code anyway. That makes sense. -- Peter Eisentraut http://w

Re: pgsql: Transforms for jsonb to PL/Python

2018-04-02 Thread Devrim Gündüz
Hi, On Mon, 2018-04-02 at 10:59 -0400, Tom Lane wrote: > aholehole and arapaima are evidently using the platform-supplied version > on RHEL 5, and locust the platform-supplied version on macOS 10.5.8. Yeah, I'm running arapaima and aholehole, they have stock RHEL 5 packages (Python 2.4) > So wh

Re: pgsql: Transforms for jsonb to PL/Python

2018-04-02 Thread Tom Lane
Devrim =?ISO-8859-1?Q?G=FCnd=FCz?= writes: > On Sun, 2018-04-01 at 18:07 -0400, Tom Lane wrote: >> 4. Move our minimum supported Python version up to 2.6 (from 2.4 >> where it is now). >> >> #4 seems like an overreaction at first sight, but on the other >> hand, I wonder how many people really ca

Re: pgsql: Transforms for jsonb to PL/Python

2018-04-01 Thread Devrim Gündüz
Hi, On Sun, 2018-04-01 at 18:07 -0400, Tom Lane wrote: > 4. Move our minimum supported Python version up to 2.6 (from 2.4 > where it is now). > > #4 seems like an overreaction at first sight, but on the other > hand, I wonder how many people really care about pre-2.6 anymore > anyway. (2.4 was

Re: pgsql: Transforms for jsonb to PL/Python

2018-04-01 Thread Tom Lane
I wrote: > gaur (python 2.5) is showing a different output pathology: A bit of google research indicates that Python did not have reliable handling of infinity or NaN floats until 2.6; before that, you could get failures or platform-specific results from code like float('inf'). So this test ain't

Re: pgsql: Transforms for jsonb to PL/Python

2018-03-30 Thread Tom Lane
Peter Eisentraut writes: > I'm looking into the regression test failures that appear to be minor > output differences. gaur (python 2.5) is showing a different output pathology: *** 246,253 return x $$; SELECT test1inf(); ! ERROR: could not convert value "inf" to jsonb ! CONTEXT: wh

Re: pgsql: Transforms for jsonb to PL/Python

2018-03-28 Thread Peter Eisentraut
On 3/28/18 08:39, Peter Eisentraut wrote: > Transforms for jsonb to PL/Python Needs fixes for Windows build. I can give it a blind attempt, but help would be welcome. I'm looking into the regression test failures that appear to be minor output differences. -- Peter Eisentraut http