Re: pgsql: Try to unbreak MSVC builds for pg_waldump

2023-04-08 Thread Andrew Dunstan
On 2023-04-08 Sa 14:13, Andres Freund wrote: Hi, On 2023-04-08 13:53:34 -0400, Tom Lane wrote: Peter Geoghegan writes: I was under the impression that issues like this would be caught by CI. We used to have an MSVC CI target, but that's no longer the case -- not since commit e6b6ea02. I'll n

Re: pgsql: Try to unbreak MSVC builds for pg_waldump

2023-04-08 Thread Andres Freund
Hi, On 2023-04-08 13:53:34 -0400, Tom Lane wrote: > Peter Geoghegan writes: > > I was under the impression that issues like this would be caught by > > CI. We used to have an MSVC CI target, but that's no longer the case > > -- not since commit e6b6ea02. I'll need to remember that. > > I thought

Re: pgsql: Try to unbreak MSVC builds for pg_waldump

2023-04-08 Thread Peter Geoghegan
On Sat, Apr 8, 2023 at 10:53 AM Tom Lane wrote: > I thought we were planning to drop the MSVC build scripts for v16. > Is that no longer happening? If they're going to be around for > awhile, maybe that CI job needs to be resurrected. It seems as if commit e6b6ea02 had very good reasons to repla

Re: pgsql: Try to unbreak MSVC builds for pg_waldump

2023-04-08 Thread Tom Lane
Peter Geoghegan writes: > I was under the impression that issues like this would be caught by > CI. We used to have an MSVC CI target, but that's no longer the case > -- not since commit e6b6ea02. I'll need to remember that. I thought we were planning to drop the MSVC build scripts for v16. Is th

Re: pgsql: Try to unbreak MSVC builds for pg_waldump

2023-04-08 Thread Peter Geoghegan
On Sat, Apr 8, 2023 at 8:22 AM Andrew Dunstan wrote: > Try to unbreak MSVC builds for pg_waldump > > remedy an omission in commit 7d8219a444 Thanks for taking care of this. I was under the impression that issues like this would be caught by CI. We used to have an MSVC CI target, but that's no lo