Re: pgsql: Update pg_upgrade test for reg* to include regrole and regnamesp

2018-11-27 Thread Andrew Dunstan
On 11/27/18 3:38 PM, Andres Freund wrote: Hi, On 2018-11-27 10:47:29 -0500, Tom Lane wrote: Andrew Dunstan writes: In any case, I think we will probably need to bite the bullet and have pg_dump render LOs in OID order. +1. Looking at the relevant code: /* * Currently, we re-fe

Re: pgsql: Update pg_upgrade test for reg* to include regrole and regnamesp

2018-11-27 Thread Andres Freund
Hi, On 2018-11-27 10:47:29 -0500, Tom Lane wrote: > Andrew Dunstan writes: > > In any case, I think we will probably need to bite the bullet and have > > pg_dump render LOs in OID order. > > +1. Looking at the relevant code: > > /* > * Currently, we re-fetch all BLOB OIDs using a cur

Re: pgsql: Update pg_upgrade test for reg* to include regrole and regnamesp

2018-11-27 Thread Tom Lane
Andrew Dunstan writes: > In any case, I think we will probably need to bite the bullet and have > pg_dump render LOs in OID order. +1. Looking at the relevant code: /* * Currently, we re-fetch all BLOB OIDs using a cursor. Consider scanning * the already-in-memory dumpable objec

Re: pgsql: Update pg_upgrade test for reg* to include regrole and regnamesp

2018-11-27 Thread Andrew Dunstan
On 11/27/18 1:32 AM, Andres Freund wrote: The cross-version bug around pg_largeobject_metadata ought to be fixed now. I'm hoping for a response by Andrew about the ordering bit, you're welcome to opine on that too. I see that prairiedog https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=

Re: pgsql: Update pg_upgrade test for reg* to include regrole and regnamesp

2018-11-26 Thread Andres Freund
Hi, On 2018-11-27 00:43:43 -0500, Tom Lane wrote: > Andres Freund writes: > > Update pg_upgrade test for reg* to include regrole and regnamespace. > > This has broken all the back-branch cross-version upgrade tests, Hm, darn it. Gotta rewrite the query to reference those new types without the r

Re: pgsql: Update pg_upgrade test for reg* to include regrole and regnamesp

2018-11-26 Thread Tom Lane
Andres Freund writes: > Update pg_upgrade test for reg* to include regrole and regnamespace. This has broken all the back-branch cross-version upgrade tests, to go along with the HEAD cases you already broke :-( regards, tom lane