Re: pgsql: instr_time: Represent time as an int64 on all platforms

2023-01-24 Thread Andres Freund
Hi, On 2023-01-23 01:20:54 -0500, Tom Lane wrote: > I'm inclined to think that we should fix the plpython code to be rigorous > about including everything else we need before including the Python > headers. I tried that, but I think it's hard with the current split of plpython headers. Several of

Re: pgsql: instr_time: Represent time as an int64 on all platforms

2023-01-23 Thread Andres Freund
Hi, On 2023-01-23 01:55:19 -0500, Tom Lane wrote: > Andres Freund writes: > > On 2023-01-23 01:20:54 -0500, Tom Lane wrote: > >> Yeah, there was some discussion about that already: > >> https://www.postgresql.org/message-id/20230121190303.7xjiwdg3gvb62...@awork3.anarazel.de > > > I was thinking

Re: pgsql: instr_time: Represent time as an int64 on all platforms

2023-01-22 Thread Tom Lane
Andres Freund writes: > On 2023-01-23 01:20:54 -0500, Tom Lane wrote: >> Yeah, there was some discussion about that already: >> https://www.postgresql.org/message-id/20230121190303.7xjiwdg3gvb62...@awork3.anarazel.de > I was thinking of starting a starting a separate thread about it - it's > most

Re: pgsql: instr_time: Represent time as an int64 on all platforms

2023-01-22 Thread Andres Freund
Hi, On 2023-01-23 01:20:54 -0500, Tom Lane wrote: > Michael Paquier writes: > > On Sat, Jan 21, 2023 at 05:25:19AM +, Andres Freund wrote: > >> instr_time: Represent time as an int64 on all platforms > > > hoverfly is unhappy since this went in: > > https://buildfarm.postgresql.org/cgi-bin/s

Re: pgsql: instr_time: Represent time as an int64 on all platforms

2023-01-22 Thread Tom Lane
Michael Paquier writes: > On Sat, Jan 21, 2023 at 05:25:19AM +, Andres Freund wrote: >> instr_time: Represent time as an int64 on all platforms > hoverfly is unhappy since this went in: > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=hoverfly&dt=2023-01-23%2005%3A01%3A44 Yeah, ther

Re: pgsql: instr_time: Represent time as an int64 on all platforms

2023-01-22 Thread Michael Paquier
Hi Andres, On Sat, Jan 21, 2023 at 05:25:19AM +, Andres Freund wrote: > instr_time: Represent time as an int64 on all platforms > > Until now we used struct timespec for instr_time on all platforms but > windows. Using struct timespec causes a fair bit of memory (struct timeval is > 16 bytes)