Re: pgsql: windows: Define WIN32_LEAN_AND_MEAN to make compilation faster.

2021-11-06 Thread Andres Freund
On 2021-11-06 15:41:45 -0700, Andres Freund wrote: > Unless you're already done with that by the time I git pull, I'm gonna remove > that redundant WIN32_LEAN_AND_MEAN. Done.

Re: pgsql: windows: Define WIN32_LEAN_AND_MEAN to make compilation faster.

2021-11-06 Thread Tom Lane
Andres Freund writes: > There's a semi-related weirdness: Several src/port/ files include > themselves (I guess that could be seen as prep for dropping windows.h from > win32_port.h). Hmm. > Unless you're already done with that by the time I git pull, I'm gonna remove > that redundant WIN32_LEA

Re: pgsql: windows: Define WIN32_LEAN_AND_MEAN to make compilation faster.

2021-11-06 Thread Andres Freund
Hi, On 2021-11-06 18:24:21 -0400, Tom Lane wrote: > Andres Freund writes: > > windows: Define WIN32_LEAN_AND_MEAN to make compilation faster. > > I happened to notice from grepping that > src/backend/port/win32/crashdump.c has its own > > #define WIN32_LEAN_AND_MEAN > > Can't we remove that now

Re: pgsql: windows: Define WIN32_LEAN_AND_MEAN to make compilation faster.

2021-11-06 Thread Tom Lane
Andres Freund writes: > windows: Define WIN32_LEAN_AND_MEAN to make compilation faster. I happened to notice from grepping that src/backend/port/win32/crashdump.c has its own #define WIN32_LEAN_AND_MEAN Can't we remove that now? (I kind of wonder what good it did at all, considering postgres.h