Re: pgsql: Add 'noError' argument to encoding conversion functions.

2021-04-06 Thread Heikki Linnakangas
On 03/04/2021 05:53, Michael Paquier wrote: On Fri, Apr 02, 2021 at 06:53:37PM -0500, Jaime Casanova wrote: sqlsmith thinks that test_enc_conversion() must be marked as STRICT. It crashes with something like this: This one has won an open item. Fixed by adding STRICT. Thanks! - Heikki

Re: pgsql: Add 'noError' argument to encoding conversion functions.

2021-04-02 Thread Michael Paquier
On Fri, Apr 02, 2021 at 06:53:37PM -0500, Jaime Casanova wrote: > sqlsmith thinks that test_enc_conversion() must be marked as STRICT. It > crashes with something like this: This one has won an open item. -- Michael signature.asc Description: PGP signature

Re: pgsql: Add 'noError' argument to encoding conversion functions.

2021-04-02 Thread Jaime Casanova
On Thu, Apr 01, 2021 at 09:25:00AM +, Heikki Linnakangas wrote: > > Add regression tests for built-in encoding conversions. This doesn't cover > every conversion, but it covers all the internal functions in conv.c that > are used to implement the conversions. > sqlsmith thinks that test_enc_

pgsql: Add 'noError' argument to encoding conversion functions.

2021-04-01 Thread Heikki Linnakangas
Add 'noError' argument to encoding conversion functions. With the 'noError' argument, you can try to convert a buffer without knowing the character boundaries beforehand. The functions now need to return the number of input bytes successfully converted. This is is a backwards-incompatible change,