Re: pgsql: Add --exclude-database option to pg_dumpall

2019-03-01 Thread Tom Lane
Andrew Dunstan writes: > [ getopt has platform-dependent error message spelling ] > > I'm somewhat inclined just to abandon the test. It's at best of marginal > use. Agreed. It seems barely worth the test cycles to begin with, and surely not worth coping with all the different ways this error me

Re: pgsql: Add --exclude-database option to pg_dumpall

2019-03-01 Thread Andrew Dunstan
On 3/1/19 12:56 PM, Andrew Dunstan wrote: > On 3/1/19 12:04 PM, Tom Lane wrote: >> Andrew Dunstan writes: >>> Add --exclude-database option to pg_dumpall >> Buildfarm seems to think you got the test case wrong ... >> >> > > Hmm, Of course I tested this. It's passing on Linu

Re: pgsql: Add --exclude-database option to pg_dumpall

2019-03-01 Thread Andrew Dunstan
On 3/1/19 12:04 PM, Tom Lane wrote: > Andrew Dunstan writes: >> Add --exclude-database option to pg_dumpall > Buildfarm seems to think you got the test case wrong ... > > Hmm, Of course I tested this. It's passing on Linux boxes like crake and prion, but failing on OSX a

Re: pgsql: Add --exclude-database option to pg_dumpall

2019-03-01 Thread Tom Lane
Andrew Dunstan writes: > Add --exclude-database option to pg_dumpall Buildfarm seems to think you got the test case wrong ... regards, tom lane

pgsql: Add --exclude-database option to pg_dumpall

2019-03-01 Thread Andrew Dunstan
Add --exclude-database option to pg_dumpall This option functions similarly to pg_dump's --exclude-table option, but for database names. The option can be given once, and the argument can be a pattern including wildcard characters. Author: Andrew Dunstan. Reviewd-by: Fabien Coelho and Michael Paq