Re: pgsql: Add VACUUM/ANALYZE BUFFER_USAGE_LIMIT option

2023-04-11 Thread David Rowley
On Tue, 11 Apr 2023 at 18:29, Kyotaro Horiguchi wrote: > My point was just that "valid" seems redundant. (Sorry, but..) > However, looking again, many of the "cases" are like "requires a > value", which looks womewhat similar to "requires a valid > value" when the cannot be represented by a word

Re: pgsql: Add VACUUM/ANALYZE BUFFER_USAGE_LIMIT option

2023-04-10 Thread Kyotaro Horiguchi
At Tue, 11 Apr 2023 16:53:42 +1200, David Rowley wrote in > On Tue, 11 Apr 2023 at 15:02, Kyotaro Horiguchi > wrote: > > > postgres=# vacuum (buffer_usage_limit); > > > ERROR: buffer_usage_limit requires a valid value > > > > The error message doesn't really make much sense to me. In the sam

Re: pgsql: Add VACUUM/ANALYZE BUFFER_USAGE_LIMIT option

2023-04-10 Thread David Rowley
On Tue, 11 Apr 2023 at 15:02, Kyotaro Horiguchi wrote: > > postgres=# vacuum (buffer_usage_limit); > > ERROR: buffer_usage_limit requires a valid value > > The error message doesn't really make much sense to me. In the same > context, most of the code seems to use ("%s requires a parameter", > b

Re: pgsql: Add VACUUM/ANALYZE BUFFER_USAGE_LIMIT option

2023-04-10 Thread Kyotaro Horiguchi
I apologize for writing mails in such a sporadic manner.. At Tue, 11 Apr 2023 10:23:35 +0900 (JST), Kyotaro Horiguchi wrote in > Hello. > > > Add VACUUM/ANALYZE BUFFER_USAGE_LIMIT option > > This commit added the following error message. > > > errmsg("value: \"%s\": is invalid f

Re: pgsql: Add VACUUM/ANALYZE BUFFER_USAGE_LIMIT option

2023-04-10 Thread David Rowley
On Tue, 11 Apr 2023 at 13:23, Kyotaro Horiguchi wrote: > This commit added the following error message. > > >errmsg("value: \"%s\": is invalid for buffer_usage_limit", > > It looks as the follows on terminal. > > postgres=# vacuum (buffer_usage_limit 'x'); > ERROR: value: "x": is

Re: pgsql: Add VACUUM/ANALYZE BUFFER_USAGE_LIMIT option

2023-04-10 Thread Kyotaro Horiguchi
Hello. > Add VACUUM/ANALYZE BUFFER_USAGE_LIMIT option This commit added the following error message. >errmsg("value: \"%s\": is invalid for buffer_usage_limit", It looks as the follows on terminal. postgres=# vacuum (buffer_usage_limit 'x'); ERROR: value: "x": is invalid for b

pgsql: Add VACUUM/ANALYZE BUFFER_USAGE_LIMIT option

2023-04-06 Thread David Rowley
Add VACUUM/ANALYZE BUFFER_USAGE_LIMIT option Add new options to the VACUUM and ANALYZE commands called BUFFER_USAGE_LIMIT to allow users more control over how large to make the buffer access strategy that is used to limit the usage of buffers in shared buffers. Larger rings can allow VACUUM to ru