Re: pgsql: Add basic TAP tests for psql's tab-completion logic.

2020-01-03 Thread Tom Lane
Michael Paquier writes: > This has the disadvantage to have people never actually notice if the > tests are running or not because this does not generate a dependency > error. Skipping things if libreadline is not around is perfectly fine > IMO, but I think that we should harden things for IO::Pt

Re: pgsql: Add basic TAP tests for psql's tab-completion logic.

2020-01-03 Thread Michael Paquier
On Thu, Jan 02, 2020 at 08:02:29PM +, Tom Lane wrote: > Add basic TAP tests for psql's tab-completion logic. > > Up to now, psql's tab-complete.c has had exactly no regression test > coverage. This patch is an experimental attempt to add some. > > This needs Perl's IO::Pty module, which isn'

pgsql: Add basic TAP tests for psql's tab-completion logic.

2020-01-02 Thread Tom Lane
Add basic TAP tests for psql's tab-completion logic. Up to now, psql's tab-complete.c has had exactly no regression test coverage. This patch is an experimental attempt to add some. This needs Perl's IO::Pty module, which isn't installed everywhere, so the test script just skips all tests if tha