Re: pgsql: Add copy/equal support for XID lists

2022-07-12 Thread Alvaro Herrera
On 2022-Jul-12, Tom Lane wrote: > What about outfuncs/readfuncs? I see that you fixed _outList, > but not its caller outNode: > > else if (IsA(obj, List) || IsA(obj, IntList) || IsA(obj, OidList)) > _outList(str, obj); > > and the LEFT_PAREN case in nodeRead() doesn't know w

Re: pgsql: Add copy/equal support for XID lists

2022-07-12 Thread Tom Lane
Alvaro Herrera writes: > Add copy/equal support for XID lists What about outfuncs/readfuncs? I see that you fixed _outList, but not its caller outNode: else if (IsA(obj, List) || IsA(obj, IntList) || IsA(obj, OidList)) _outList(str, obj); and the LEFT_PAREN case in node

pgsql: Add copy/equal support for XID lists

2022-07-12 Thread Alvaro Herrera
Add copy/equal support for XID lists Commit f10a025cfe97 added support for List to store Xids, but didn't handle the new type in all cases. Add some obviously necessary pieces. As far as I am aware, this is all dead code as far as core code is concerned, but it seems unacceptable not to have it i