Re: pgsql: Add documentation for the JIT feature.

2018-03-31 Thread Alvaro Herrera
Tom Lane wrote: > Andres Freund writes: > > On March 31, 2018 8:43:37 AM PDT, Tom Lane wrote: > >> I don't want to waste cycles on testing docs when I'm trying > >> to test code, any more than I would like the reverse (ie forcing a docs > >> build to build

Re: pgsql: Add documentation for the JIT feature.

2018-03-31 Thread Tom Lane
Andres Freund writes: > On March 31, 2018 8:43:37 AM PDT, Tom Lane wrote: >> I don't want to waste cycles on testing docs when I'm trying >> to test code, any more than I would like the reverse (ie forcing a docs >> build to build code too). > They're a

Re: pgsql: Add documentation for the JIT feature.

2018-03-31 Thread Andres Freund
On March 31, 2018 8:43:37 AM PDT, Tom Lane wrote: >Peter Eisentraut writes: >> On 3/29/18 14:43, Alvaro Herrera wrote: > I'm *not* OK with expanding the scope of "make check" >to include building the documentation. It's never had anything

Re: pgsql: Add documentation for the JIT feature.

2018-03-31 Thread Tom Lane
Peter Eisentraut writes: > On 3/29/18 14:43, Alvaro Herrera wrote: >>> Hm, what's wrong just doing it in the normal build? It's a desired build >>> artifact, so I really don't see any argument for not building it by >>> default? Don't quite see what the

Re: pgsql: Add documentation for the JIT feature.

2018-03-31 Thread Peter Eisentraut
On 3/29/18 14:43, Alvaro Herrera wrote: >> Hm, what's wrong just doing it in the normal build? It's a desired build >> artifact, so I really don't see any argument for not building it by >> default? Don't quite see what the advantage of doing it during make >> check would be? > I meant running

Re: pgsql: Add documentation for the JIT feature.

2018-03-29 Thread Alvaro Herrera
Andres Freund wrote: > Hi, > > On 2018-03-29 15:20:58 -0300, Alvaro Herrera wrote: > > Andres Freund wrote: > > > > > Could we add INSTALL to the all target in src/docs/sgml? It's a bit > > > awkward that one can build the docs and miss such a mistake. It's fast > > > to build in comparison to

Re: pgsql: Add documentation for the JIT feature.

2018-03-29 Thread Andres Freund
Hi, On 2018-03-29 15:20:58 -0300, Alvaro Herrera wrote: > Andres Freund wrote: > > > Could we add INSTALL to the all target in src/docs/sgml? It's a bit > > awkward that one can build the docs and miss such a mistake. It's fast > > to build in comparison to the rest of the docs, so that doesn't

Re: pgsql: Add documentation for the JIT feature.

2018-03-29 Thread Alvaro Herrera
Andres Freund wrote: > Could we add INSTALL to the all target in src/docs/sgml? It's a bit > awkward that one can build the docs and miss such a mistake. It's fast > to build in comparison to the rest of the docs, so that doesn't seem > like a high price? Maybe it can be tested for in "make

Re: pgsql: Add documentation for the JIT feature.

2018-03-28 Thread Simon Riggs
On 28 March 2018 at 22:23, Andres Freund wrote: > Add documentation for the JIT feature. Very nice feature and most welcome but we should call it something other than just "JIT" JIT means Just In Time, which could be applied to many concepts and has been in use for many

pgsql: Add documentation for the JIT feature.

2018-03-28 Thread Andres Freund
Add documentation for the JIT feature. As promised in earlier commits, this adds documentation about the new build options, the new GUCs, about the planner logic when JIT is used, and the benefits of JIT in general. Also adds a more implementation oriented README. I'm sure we're going to want