Re: pgsql: Add functions to 'pageinspect' to inspect GiST indexes.

2021-02-14 Thread Peter Geoghegan
On Thu, Feb 11, 2021 at 9:22 PM Andrey Borodin wrote: > Thanks, Peter! I agree that taking PageGetMaxOffsetNumber() seems > incorrect for deleted page, because we set pd_lower for the deleted page. > Also, there was an idea to add a column for LP_DEAD. > As long as we are dealing with deleted data

Re: pgsql: Add functions to 'pageinspect' to inspect GiST indexes.

2021-02-11 Thread Andrey Borodin
> 12 февр. 2021 г., в 01:53, Peter Geoghegan написал(а): > > On Wed, Jan 13, 2021 at 12:36 AM Heikki Linnakangas > wrote: >> Add functions to 'pageinspect' to inspect GiST indexes. > > Is gist_page_items() robust with deleted pages? I think that it's > unsafe to assume that deleted pages will

Re: pgsql: Add functions to 'pageinspect' to inspect GiST indexes.

2021-02-11 Thread Peter Geoghegan
On Wed, Jan 13, 2021 at 12:36 AM Heikki Linnakangas wrote: > Add functions to 'pageinspect' to inspect GiST indexes. Is gist_page_items() robust with deleted pages? I think that it's unsafe to assume that deleted pages will have index tuples, since the page contents will actually be a GISTDeleted

pgsql: Add functions to 'pageinspect' to inspect GiST indexes.

2021-01-13 Thread Heikki Linnakangas
Add functions to 'pageinspect' to inspect GiST indexes. Author: Andrey Borodin and me Discussion: https://www.postgresql.org/message-id/3E4F9093-A1B5-4DF8-A292-0B48692E3954%40yandex-team.ru Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/756ab29124d7850d4392e2227b6