Re: pgsql: Add per-index stats information in verbose logs of autovacuum

2021-03-23 Thread Peter Geoghegan
On Tue, Mar 23, 2021 at 5:38 PM Michael Paquier wrote: > No arguments against that, makes sense. I have applied something that > changes "remain" to "in total" for clarity. Thanks! Thanks! -- Peter Geoghegan

Re: pgsql: Add per-index stats information in verbose logs of autovacuum

2021-03-23 Thread Michael Paquier
On Mon, Mar 22, 2021 at 11:34:47PM -0700, Peter Geoghegan wrote: > I'm okay with preserving "pages:" if you prefer it that way. It's > really just the word "remain" -- it reminds me of the old > "pages_removed" field. That used to be a thing that we showed back > when old-style VACUUM existed and c

Re: pgsql: Add per-index stats information in verbose logs of autovacuum

2021-03-22 Thread Peter Geoghegan
On Mon, Mar 22, 2021 at 11:22 PM Michael Paquier wrote: > > To be clear, I agree that it would not be sensible to make the > > log_autovacuum_min_duration output 100% consistent with VACUUM > > VERBOSE. I just think that "%u remain" is misleading. It's just that > > one detail. > > Saying that, I

Re: pgsql: Add per-index stats information in verbose logs of autovacuum

2021-03-22 Thread Michael Paquier
On Mon, Mar 22, 2021 at 10:36:03PM -0700, Peter Geoghegan wrote: > It suggests that the index file can shrink. As if the remaining pages > are left now that the pages we deleted have been returned to the OS. I > think that this same line of output should look like this instead: > > index "

Re: pgsql: Add per-index stats information in verbose logs of autovacuum

2021-03-22 Thread Peter Geoghegan
On Mon, Mar 22, 2021 at 9:28 PM Michael Paquier wrote: > Add per-index stats information in verbose logs of autovacuum I think that this is very helpful -- thanks for working on it. However, it seems to me that "%u remain" is misleading. I am referring to this line of output: index "dups

pgsql: Add per-index stats information in verbose logs of autovacuum

2021-03-22 Thread Michael Paquier
Add per-index stats information in verbose logs of autovacuum Once a relation's autovacuum is completed, the logs include more information about this relation state if the threshold of log_autovacuum_min_duration (or its relation option) is reached, with for example contents about the statistics o