On Wed, Dec 6, 2017 at 8:03 AM, Andres Freund wrote:
> On 2017-12-05 12:59:21 +1300, Thomas Munro wrote:
>> src/backend/commands/explain.c | 58 ++--
>
> This didn't actually include nodeHash.h, ...
Ugh, I'd lost -Werror from my COPT. Back in there it goes.
> Pushed, thank
Hi,
On 2017-12-05 12:59:21 +1300, Thomas Munro wrote:
> src/backend/commands/explain.c | 58 ++--
This didn't actually include nodeHash.h, therefore
ExecHashGetInstrumentation() didn't have a prototype. I added the
relevant include and remove the hashjoin.h include which isn
On Tue, Dec 5, 2017 at 9:21 AM, Andres Freund wrote:
> On 2017-12-04 12:28:56 +1300, Thomas Munro wrote:
>> From 43eeea0bc35204440d262224b56efca958b33428 Mon Sep 17 00:00:00 2001
>> From: Thomas Munro
>> Date: Mon, 4 Dec 2017 11:52:11 +1300
>> Subject: [PATCH] Fix EXPLAIN ANALYZE of hash join whe
On 2017-12-04 12:28:56 +1300, Thomas Munro wrote:
> From 43eeea0bc35204440d262224b56efca958b33428 Mon Sep 17 00:00:00 2001
> From: Thomas Munro
> Date: Mon, 4 Dec 2017 11:52:11 +1300
> Subject: [PATCH] Fix EXPLAIN ANALYZE of hash join when the leader doesn't
> execute.
>
> If a hash join appears
On Mon, Dec 4, 2017 at 12:18 PM, Thomas Munro
wrote:
> On Mon, Dec 4, 2017 at 9:12 AM, Thomas Munro
> wrote:
>> On Mon, Dec 4, 2017 at 7:39 AM, Andres Freund wrote:
>>> On 2017-11-30 08:06:44 -0800, Andres Freund wrote:
At the current rate of failure I'm slightly inclined to just leave the
On Mon, Dec 4, 2017 at 9:12 AM, Thomas Munro
wrote:
> On Mon, Dec 4, 2017 at 7:39 AM, Andres Freund wrote:
>> On 2017-11-30 08:06:44 -0800, Andres Freund wrote:
>>> At the current rate of failure I'm slightly inclined to just leave the
>>> occasionally failing test, which sounds like an actual bu
On Mon, Dec 4, 2017 at 7:39 AM, Andres Freund wrote:
> On 2017-11-30 08:06:44 -0800, Andres Freund wrote:
>> At the current rate of failure I'm slightly inclined to just leave the
>> occasionally failing test, which sounds like an actual bug imo, in place
>> till we have the fix. But if there's a
On 2017-11-30 08:06:44 -0800, Andres Freund wrote:
> Hi,
>
> On 2017-11-30 23:53:55 +1300, Thomas Munro wrote:
> > On Thu, Nov 30, 2017 at 4:47 PM, Thomas Munro
> > wrote:
> > > On Thu, Nov 30, 2017 at 4:13 PM, Tom Lane wrote:
> > >> Andres Freund writes:
> > >>> Add some regression tests that
Hi,
On 2017-11-30 23:53:55 +1300, Thomas Munro wrote:
> On Thu, Nov 30, 2017 at 4:47 PM, Thomas Munro
> wrote:
> > On Thu, Nov 30, 2017 at 4:13 PM, Tom Lane wrote:
> >> Andres Freund writes:
> >>> Add some regression tests that exercise hash join code.
> >>
> >> At least one buildfarm member do
On Thu, Nov 30, 2017 at 4:47 PM, Thomas Munro
wrote:
> On Thu, Nov 30, 2017 at 4:13 PM, Tom Lane wrote:
>> Andres Freund writes:
>>> Add some regression tests that exercise hash join code.
>>
>> At least one buildfarm member doesn't like this ...
>
> $$);
>initially_multibatch | increased_
On Thu, Nov 30, 2017 at 4:13 PM, Tom Lane wrote:
> Andres Freund writes:
>> Add some regression tests that exercise hash join code.
>
> At least one buildfarm member doesn't like this ...
$$);
initially_multibatch | increased_batches
--+---
! t
Andres Freund writes:
> Add some regression tests that exercise hash join code.
At least one buildfarm member doesn't like this ...
regards, tom lane
Add some regression tests that exercise hash join code.
Although hash joins are already tested by many queries, these tests
systematically cover the four different states we can reach as part of
the strategy for respecting work_mem.
Author: Thomas Munro
Reviewed-By: Andres Freund
Branch
--
m
13 matches
Mail list logo
