Re: pgsql: Add template for adaptive radix tree

On Fri, Mar 8, 2024 at 10:43 AM David Rowley wrote: > > On Fri, 8 Mar 2024 at 16:37, John Naylor wrote: > > Thanks, I was getting close to committing a hackish workaround -- this > > seems better! > > ok cool. I also noticed a typo. Maybe worth fixing that at the same time? > > Attached. Done,

Re: pgsql: Add template for adaptive radix tree

On Fri, 8 Mar 2024 at 16:37, John Naylor wrote: > Thanks, I was getting close to committing a hackish workaround -- this > seems better! ok cool. I also noticed a typo. Maybe worth fixing that at the same time? Attached. David diff --git a/src/test/modules/test_radixtree/test_radixtree.c b/sr

Re: pgsql: Add template for adaptive radix tree

On Fri, Mar 8, 2024 at 10:29 AM David Rowley wrote: > > On Fri, 8 Mar 2024 at 13:48, John Naylor wrote: > > Now, after I get some coffee I'll look into the Windows failures. > > I had a look at this and the attached fixes the broken build on MSVC for me. > > I didn't take the time to fully unders

Re: pgsql: Add template for adaptive radix tree

On Fri, 8 Mar 2024 at 13:48, John Naylor wrote: > Now, after I get some coffee I'll look into the Windows failures. I had a look at this and the attached fixes the broken build on MSVC for me. I didn't take the time to fully understand it, but I did also try PGDLLEXPORT and that *didn't* fix it.

Re: pgsql: Add template for adaptive radix tree

On Thu, Mar 7, 2024 at 4:47 PM John Naylor wrote: > > On Thu, Mar 7, 2024 at 4:36 PM Alvaro Herrera wrote: > > > > Well, surely we can email them. Their profiles show they're still > > active. > > https://db.in.tum.de/people/sites/kemper/?lang=en > > https://db.in.tum.de/people/sites/neumann/?la

Re: pgsql: Add template for adaptive radix tree

On 2024-03-07 Th 00:49, John Naylor wrote: Add template for adaptive radix tree drongo and fairywren don't like this, See e.g. cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.c

Re: pgsql: Add template for adaptive radix tree

On Thu, Mar 7, 2024 at 4:36 PM Alvaro Herrera wrote: > > Well, surely we can email them. Their profiles show they're still > active. > https://db.in.tum.de/people/sites/kemper/?lang=en > https://db.in.tum.de/people/sites/neumann/?lang=en > https://db.in.tum.de/people/sites/leis/?lang=en I though

Re: pgsql: Add template for adaptive radix tree

On 2024-Mar-07, John Naylor wrote: > Understandably so. FWIW, the use case proposed by the authors was for > secondary indexes within in-memory databases, not as a type of > associative array. I'm unable to find patents for the thing itself, > but IANAL. I believe I've been in contact with some of

Re: pgsql: Add template for adaptive radix tree

On Thu, Mar 7, 2024 at 1:32 PM Tom Lane wrote: > > John Naylor writes: > > On Thu, Mar 7, 2024 at 1:08 PM Tom Lane wrote: > >> Hm ... do we know that this is not patent-encumbered technology? > >> Commits citing such specific prior art make me nervous. > > > There are several open source impleme

Re: pgsql: Add template for adaptive radix tree

John Naylor writes: > On Thu, Mar 7, 2024 at 1:08 PM Tom Lane wrote: >> Hm ... do we know that this is not patent-encumbered technology? >> Commits citing such specific prior art make me nervous. > There are several open source implementations in a variety of > languages, so I assumed not. Are

Re: pgsql: Add template for adaptive radix tree

On Thu, Mar 7, 2024 at 1:08 PM Tom Lane wrote: > > John Naylor writes: > > This implements a radix tree data structure based on the design in > > "The Adaptive Radix Tree: ARTful Indexing for Main-Memory Databases" > > by Viktor Leis, Alfons Kemper, and ThomasNeumann, 2013. > > Hm ... do we know

Re: pgsql: Add template for adaptive radix tree

John Naylor writes: > This implements a radix tree data structure based on the design in > "The Adaptive Radix Tree: ARTful Indexing for Main-Memory Databases" > by Viktor Leis, Alfons Kemper, and ThomasNeumann, 2013. Hm ... do we know that this is not patent-encumbered technology? Commits citing

pgsql: Add template for adaptive radix tree

Add template for adaptive radix tree This implements a radix tree data structure based on the design in "The Adaptive Radix Tree: ARTful Indexing for Main-Memory Databases" by Viktor Leis, Alfons Kemper, and ThomasNeumann, 2013. The main technique that makes it adaptive is using several different