Re: pgsql: Add tests for reinit.c

2018-03-19 Thread David Steele
On 3/19/18 5:58 PM, Andrew Dunstan wrote: > On Mon, Mar 19, 2018 at 11:33 PM, David Steele wrote: >> On 3/19/18 4:15 AM, Andrew Dunstan wrote: >>> >>> The attached fixes it. We should probably put the function or something >>> like it in TestLib.pm, though. The call to pwd is quite tricky - it >>>

Re: pgsql: Add tests for reinit.c

2018-03-19 Thread Andrew Dunstan
On Mon, Mar 19, 2018 at 11:33 PM, David Steele wrote: > On 3/19/18 4:15 AM, Andrew Dunstan wrote: >> >> The attached fixes it. We should probably put the function or something >> like it in TestLib.pm, though. The call to pwd is quite tricky - it >> needs to be done pretty much exactly like this,

Re: pgsql: Add tests for reinit.c

2018-03-19 Thread David Steele
On 3/19/18 4:15 AM, Andrew Dunstan wrote: > > The attached fixes it. We should probably put the function or something > like it in TestLib.pm, though. The call to pwd is quite tricky - it > needs to be done pretty much exactly like this, not quite sure why, but > direct calls to "pwd -W" via syste

Re: pgsql: Add tests for reinit.c

2018-03-19 Thread Andrew Dunstan
On Sat, Mar 17, 2018 at 12:06 AM, David Steele wrote: > On 3/15/18 11:51 PM, Tom Lane wrote: > > I wrote: > >> Peter Eisentraut writes: > >>> Add tests for reinit.c > > > >> BTW, buildfarm member jacana hasn't succeeded at this test once. > >> The failures look like > > > >> ok 1 - init fork in

Re: pgsql: Add tests for reinit.c

2018-03-16 Thread David Steele
On 3/15/18 11:51 PM, Tom Lane wrote: > I wrote: >> Peter Eisentraut writes: >>> Add tests for reinit.c > >> BTW, buildfarm member jacana hasn't succeeded at this test once. >> The failures look like > >> ok 1 - init fork in base exists >> ok 2 - main fork in base exists >> error running SQL: 'ps

Re: pgsql: Add tests for reinit.c

2018-03-15 Thread Tom Lane
I wrote: > Peter Eisentraut writes: >> Add tests for reinit.c > BTW, buildfarm member jacana hasn't succeeded at this test once. > The failures look like > ok 1 - init fork in base exists > ok 2 - main fork in base exists > error running SQL: 'psql::1: ERROR: directory > "/home/pgrunner/bf/roo

Re: pgsql: Add tests for reinit.c

2018-03-15 Thread Tom Lane
Peter Eisentraut writes: > Add tests for reinit.c BTW, buildfarm member jacana hasn't succeeded at this test once. The failures look like ok 1 - init fork in base exists ok 2 - main fork in base exists error running SQL: 'psql::1: ERROR: directory "/home/pgrunner/bf/root/HEAD/pgsql.build/src/t

pgsql: Add tests for reinit.c

2018-03-14 Thread Peter Eisentraut
Add tests for reinit.c This tests how the different forks of unlogged tables behave in crash recovery. Author: David Steele Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/df411e7c664ee9a2395eb8c7a74ceddea818d489 Modified Files -- src/test/recovery/t/