Re: pgsql: Add tests for tuplesort.c.

2019-11-18 Thread Andres Freund
On 2019-11-16 10:40:17 -0800, Peter Geoghegan wrote: > On Sat, Nov 16, 2019 at 10:14 AM Andres Freund wrote: > > Indeed, thanks for catching. I'm off till Monday... If you want to push the > > addition... > > No problem. I'll push a fix now. Thanks!

Re: pgsql: Add tests for tuplesort.c.

2019-11-16 Thread Peter Geoghegan
On Sat, Nov 16, 2019 at 10:14 AM Andres Freund wrote: > Indeed, thanks for catching. I'm off till Monday... If you want to push the > addition... No problem. I'll push a fix now. -- Peter Geoghegan

Re: pgsql: Add tests for tuplesort.c.

2019-11-16 Thread Andres Freund
Hi, On November 16, 2019 10:09:19 AM PST, Peter Geoghegan wrote: >On Wed, Nov 13, 2019 at 4:09 PM Andres Freund >wrote: >> Add tests for tuplesort.c. > >> Modified Files >> -- >> src/test/regress/expected/tuplesort.out | 691 > >> src/test/regress/para

Re: pgsql: Add tests for tuplesort.c.

2019-11-16 Thread Peter Geoghegan
On Wed, Nov 13, 2019 at 4:09 PM Andres Freund wrote: > Add tests for tuplesort.c. > Modified Files > -- > src/test/regress/expected/tuplesort.out | 691 > src/test/regress/parallel_schedule | 2 +- > src/test/regress/sql/tuplesort.sql | 304 +

pgsql: Add tests for tuplesort.c.

2019-11-13 Thread Andres Freund
Add tests for tuplesort.c. Previously significant parts of tuplesort.c were untested. This commit, while not testing every path, significantly increases coverage. In particular, this adds tests for abbreviated key logic, forward/backward scans & scrolling and mark/restore. I tried to keep the ta