Re: pgsql: Add various assertions to heap pruning code.

2021-11-05 Thread Peter Geoghegan
On Thu, Nov 4, 2021 at 11:48 PM Michael Paquier wrote: > This generates some warnings on Windows without asserts: > pruneheap.c(847): warning C4101: 'htup' unreferenced local variable > pruneheap.c(859): warning C4101: 'tolp' unreferenced local variable > > You could move those two variables withi

Re: pgsql: Add various assertions to heap pruning code.

2021-11-04 Thread Michael Paquier
Hi Peter, On Fri, Nov 05, 2021 at 02:09:47AM +, Peter Geoghegan wrote: > Add various assertions to heap pruning code. > > These assertions document (and verify) our high level assumptions about > how pruning can and cannot affect existing items from target heap pages. > For example, one of th

pgsql: Add various assertions to heap pruning code.

2021-11-04 Thread Peter Geoghegan
Add various assertions to heap pruning code. These assertions document (and verify) our high level assumptions about how pruning can and cannot affect existing items from target heap pages. For example, one of the new assertions verifies that pruning does not set a heap-only tuple to LP_DEAD. Aut