Re: pgsql: Allow building with MSVC and Strawberry perl

2022-11-25 Thread Andres Freund
Hi, On 2022-11-25 18:56:02 -0500, Andrew Dunstan wrote: > On 2022-11-25 Fr 18:48, Andres Freund wrote: > > On 2022-11-25 15:33:31 -0800, Andres Freund wrote: > >> FWIW a meson build with msvc 2019 and strawberry perl 5.32 builds fine with > >> #define __builtin_expect(expr, val) (expr) > > And it

Re: pgsql: Allow building with MSVC and Strawberry perl

2022-11-25 Thread Andrew Dunstan
On 2022-11-25 Fr 18:48, Andres Freund wrote: > Hi, > > On 2022-11-25 15:33:31 -0800, Andres Freund wrote: >> FWIW a meson build with msvc 2019 and strawberry perl 5.32 builds fine with >> #define __builtin_expect(expr, val) (expr) > And it does so with src/tools/msvc as well. I think we might ne

Re: pgsql: Allow building with MSVC and Strawberry perl

2022-11-25 Thread Andres Freund
Hi, On 2022-11-25 15:33:31 -0800, Andres Freund wrote: > FWIW a meson build with msvc 2019 and strawberry perl 5.32 builds fine with > #define __builtin_expect(expr, val) (expr) And it does so with src/tools/msvc as well. I think we might need a preprocessed plperl.c from drongo to analyze this

Re: pgsql: Allow building with MSVC and Strawberry perl

2022-11-25 Thread Andres Freund
Hi, On 2022-11-25 17:11:51 -0500, Andrew Dunstan wrote: > On 2022-11-25 Fr 15:38, Andrew Dunstan wrote: > > Allow building with MSVC and Strawberry perl > > > > Strawberry uses __builtin_expect which Visual C doesn't have. For this > > case define it as a noop. Solution taken from vim sources. FW

Re: pgsql: Allow building with MSVC and Strawberry perl

2022-11-25 Thread Andrew Dunstan
On 2022-11-25 Fr 15:38, Andrew Dunstan wrote: > Allow building with MSVC and Strawberry perl > > Strawberry uses __builtin_expect which Visual C doesn't have. For this > case define it as a noop. Solution taken from vim sources. Argh! drongo doesn't seem to like this. I thought I'd tested it.

pgsql: Allow building with MSVC and Strawberry perl

2022-11-25 Thread Andrew Dunstan
Allow building with MSVC and Strawberry perl Strawberry uses __builtin_expect which Visual C doesn't have. For this case define it as a noop. Solution taken from vim sources. Backpatch to all live branches Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/ae7c

pgsql: Allow building with MSVC and Strawberry perl

2022-11-25 Thread Andrew Dunstan
Allow building with MSVC and Strawberry perl Strawberry uses __builtin_expect which Visual C doesn't have. For this case define it as a noop. Solution taken from vim sources. Backpatch to all live branches Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/171c

pgsql: Allow building with MSVC and Strawberry perl

2022-11-25 Thread Andrew Dunstan
Allow building with MSVC and Strawberry perl Strawberry uses __builtin_expect which Visual C doesn't have. For this case define it as a noop. Solution taken from vim sources. Backpatch to all live branches Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/341f4e002d4

pgsql: Allow building with MSVC and Strawberry perl

2022-11-25 Thread Andrew Dunstan
Allow building with MSVC and Strawberry perl Strawberry uses __builtin_expect which Visual C doesn't have. For this case define it as a noop. Solution taken from vim sources. Backpatch to all live branches Branch -- REL_14_STABLE Details --- https://git.postgresql.org/pg/commitdiff/f761

pgsql: Allow building with MSVC and Strawberry perl

2022-11-25 Thread Andrew Dunstan
Allow building with MSVC and Strawberry perl Strawberry uses __builtin_expect which Visual C doesn't have. For this case define it as a noop. Solution taken from vim sources. Backpatch to all live branches Branch -- REL_15_STABLE Details --- https://git.postgresql.org/pg/commitdiff/fed5

pgsql: Allow building with MSVC and Strawberry perl

2022-11-25 Thread Andrew Dunstan
Allow building with MSVC and Strawberry perl Strawberry uses __builtin_expect which Visual C doesn't have. For this case define it as a noop. Solution taken from vim sources. Backpatch to all live branches Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdiff/9fe5