Re: pgsql: Allow logical decoding on standbys

2023-04-14 Thread Kyotaro Horiguchi
At Thu, 13 Apr 2023 12:07:19 -0400, Robert Haas wrote in > On Wed, Apr 12, 2023 at 1:43=E2=80=AFPM Andres Freund = > wrote: > > > And, a nearby commit addds the following message. > > > > > > + appendStringInfo(&err_detail, _("Logical decoding= > on standby requires wal_lev

Re: pgsql: Allow logical decoding on standbys

2023-04-13 Thread Robert Haas
On Wed, Apr 12, 2023 at 1:43 PM Andres Freund wrote: > > And, a nearby commit addds the following message. > > > > + appendStringInfo(&err_detail, _("Logical decoding on > > standby requires wal_level to be at least logical on the primary server")); > > > > This is omitting th

Re: pgsql: Allow logical decoding on standbys

2023-04-13 Thread Kyotaro Horiguchi
At Wed, 12 Apr 2023 11:10:00 -0700, Andres Freund wrote in > Hi, > > On 2023-04-12 10:42:44 -0700, Andres Freund wrote: > > On 2023-04-11 12:02:53 +0900, Kyotaro Horiguchi wrote: > > > > Allow logical decoding on standbys > > > > > > This adds the following error message. > > > > > > + errmsg(

Re: pgsql: Allow logical decoding on standbys

2023-04-12 Thread Andres Freund
Hi, On 2023-04-12 10:42:44 -0700, Andres Freund wrote: > On 2023-04-11 12:02:53 +0900, Kyotaro Horiguchi wrote: > > > Allow logical decoding on standbys > > > > This adds the following error message. > > > > + errmsg("logical decoding on a standby requires wal_level to be at least > > logical

Re: pgsql: Allow logical decoding on standbys

2023-04-12 Thread Andres Freund
Hi, On 2023-04-11 12:02:53 +0900, Kyotaro Horiguchi wrote: > > Allow logical decoding on standbys > > This adds the following error message. > > + errmsg("logical decoding on a standby requires wal_level to be at least > logical on the primary"))); > > We alredy have a nearly identical mes

Re: pgsql: Allow logical decoding on standbys

2023-04-10 Thread Drouvot, Bertrand
Hi, On 4/11/23 5:02 AM, Kyotaro Horiguchi wrote: CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe. Allow logical decoding on standbys This adds the following error messag

Re: pgsql: Allow logical decoding on standbys

2023-04-10 Thread Kyotaro Horiguchi
> Allow logical decoding on standbys This adds the following error message. + errmsg("logical decoding on a standby requires wal_level to be at least logical on the primary"))); We alredy have a nearly identical message as follows. > errmsg("logical decoding requires wal_level >= logical

pgsql: Allow logical decoding on standbys

2023-04-08 Thread Andres Freund
Allow logical decoding on standbys Unsurprisingly, this requires wal_level = logical to be set on the primary and standby. The infrastructure added in 26669757b6a ensures that slots are invalidated if the primary's wal_level is lowered. Creating a slot on a standby waits for a xl_running_xact rec