Re: pgsql: Beautify initialization of JsonValueList and JsonLikeRegexContex

2019-03-17 Thread Alexander Korotkov
On Mon, Mar 18, 2019 at 7:12 AM Michael Paquier wrote: > > On Sun, Mar 17, 2019 at 03:09:07PM +0300, Alexander Korotkov wrote: > > Anyway, I thought about this as about just beautification. If it's > > bad idea, let's revert this. > > I agree with Peter's point here that having {0} as initial sta

Re: pgsql: Beautify initialization of JsonValueList and JsonLikeRegexContex

2019-03-17 Thread Michael Paquier
On Sun, Mar 17, 2019 at 03:09:07PM +0300, Alexander Korotkov wrote: > Anyway, I thought about this as about just beautification. If it's > bad idea, let's revert this. I agree with Peter's point here that having {0} as initial state is cleaner instead of adding an extra level of abstraction. -- M

Re: pgsql: Beautify initialization of JsonValueList and JsonLikeRegexContex

2019-03-17 Thread Alexander Korotkov
On Sun, Mar 17, 2019 at 3:00 PM Peter Eisentraut wrote: > On 2019-03-17 10:59, Alexander Korotkov wrote: > > Beautify initialization of JsonValueList and JsonLikeRegexContext > > > > Instead of tricky assignment to {0} introduce special macros, which > > explicitly initialize every field. > > To m

Re: pgsql: Beautify initialization of JsonValueList and JsonLikeRegexContex

2019-03-17 Thread Peter Eisentraut
On 2019-03-17 10:59, Alexander Korotkov wrote: > Beautify initialization of JsonValueList and JsonLikeRegexContext > > Instead of tricky assignment to {0} introduce special macros, which > explicitly initialize every field. To me, this patch is exactly the opposite of what I'd do to "beautify ini

pgsql: Beautify initialization of JsonValueList and JsonLikeRegexContex

2019-03-17 Thread Alexander Korotkov
Beautify initialization of JsonValueList and JsonLikeRegexContext Instead of tricky assignment to {0} introduce special macros, which explicitly initialize every field. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/4178d8b91cb943b422d1837b4b7798576d88995a Modifie