Re: pgsql: Change fastgetattr and heap_getattr to inline functions

2022-03-24 Thread Alvaro Herrera
On 2022-Mar-24, Tom Lane wrote: > wrasse isn't happy with this: > > ccache /opt/developerstudio12.6/bin/cc -m64 -Xa -v -O pg_resetwal.o > -L../../../src/port -L../../../src/common -L/home/nm/sw/nopath/uuid-64/lib > -L/home/nm/sw/nopath/openldap-64/lib -Wl,--as-needed > -Wl,-R'/home/nm/farm/

Re: pgsql: Change fastgetattr and heap_getattr to inline functions

2022-03-24 Thread Tom Lane
Alvaro Herrera writes: > Change fastgetattr and heap_getattr to inline functions wrasse isn't happy with this: ccache /opt/developerstudio12.6/bin/cc -m64 -Xa -v -O pg_resetwal.o -L../../../src/port -L../../../src/common -L/home/nm/sw/nopath/uuid-64/lib -L/home/nm/sw/nopath/openldap-64/lib

pgsql: Change fastgetattr and heap_getattr to inline functions

2022-03-24 Thread Alvaro Herrera
Change fastgetattr and heap_getattr to inline functions They were macros previously, but recent callsite additions made Coverity complain about one of the assertions being always true. This change could have been made a long time ago, but the Coverity complain broke the inertia. Reviewed-by: Mic