pgsql: Clean up error handling in pg_basebackup's walmethods.c.

2021-11-17 Thread Tom Lane
Clean up error handling in pg_basebackup's walmethods.c. The error handling here was a mess, as a result of a fundamentally bad design (relying on errno to keep its value much longer than is safe to assume) as well as a lot of just plain sloppiness, both as to noticing errors at all and as to repo

pgsql: Clean up error handling in pg_basebackup's walmethods.c.

2021-11-17 Thread Tom Lane
Clean up error handling in pg_basebackup's walmethods.c. The error handling here was a mess, as a result of a fundamentally bad design (relying on errno to keep its value much longer than is safe to assume) as well as a lot of just plain sloppiness, both as to noticing errors at all and as to repo

pgsql: Clean up error handling in pg_basebackup's walmethods.c.

2021-11-17 Thread Tom Lane
Clean up error handling in pg_basebackup's walmethods.c. The error handling here was a mess, as a result of a fundamentally bad design (relying on errno to keep its value much longer than is safe to assume) as well as a lot of just plain sloppiness, both as to noticing errors at all and as to repo

pgsql: Clean up error handling in pg_basebackup's walmethods.c.

2021-11-17 Thread Tom Lane
Clean up error handling in pg_basebackup's walmethods.c. The error handling here was a mess, as a result of a fundamentally bad design (relying on errno to keep its value much longer than is safe to assume) as well as a lot of just plain sloppiness, both as to noticing errors at all and as to repo

pgsql: Clean up error handling in pg_basebackup's walmethods.c.

2021-11-17 Thread Tom Lane
Clean up error handling in pg_basebackup's walmethods.c. The error handling here was a mess, as a result of a fundamentally bad design (relying on errno to keep its value much longer than is safe to assume) as well as a lot of just plain sloppiness, both as to noticing errors at all and as to repo

pgsql: Clean up error handling in pg_basebackup's walmethods.c.

2021-11-17 Thread Tom Lane
Clean up error handling in pg_basebackup's walmethods.c. The error handling here was a mess, as a result of a fundamentally bad design (relying on errno to keep its value much longer than is safe to assume) as well as a lot of just plain sloppiness, both as to noticing errors at all and as to repo