pgsql: Code cleanup

2023-01-11 Thread Peter Eisentraut
Code cleanup for commit c96de2ce1782116bd0489b1cd69ba88189a495e8 Author: Nathan Bossart Discussion: https://www.postgresql.org/message-id/2023085434.GA1912982@nathanxps13 Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/881fa869c6b0c4e2f310d1c145141dd9d6f53774

Re: pgsql: Code cleanup for toast_fetch_datum and toast_fetch_datum_slice.

2019-12-17 Thread Robert Haas
On Tue, Dec 17, 2019 at 3:54 PM Tom Lane wrote: > Robert Haas writes: > > On Tue, Dec 17, 2019 at 2:52 PM Robert Haas wrote: > >> Code cleanup for toast_fetch_datum and toast_fetch_datum_slice. > > > florican seems unhappy with this. Looking at it now. > > lapwing as well; maybe some 64-bit-ish

Re: pgsql: Code cleanup for toast_fetch_datum and toast_fetch_datum_slice.

2019-12-17 Thread Tom Lane
Robert Haas writes: > On Tue, Dec 17, 2019 at 2:52 PM Robert Haas wrote: >> Code cleanup for toast_fetch_datum and toast_fetch_datum_slice. > florican seems unhappy with this. Looking at it now. lapwing as well; maybe some 64-bit-ish assumptions in there? regards, tom l

Re: pgsql: Code cleanup for toast_fetch_datum and toast_fetch_datum_slice.

2019-12-17 Thread Robert Haas
On Tue, Dec 17, 2019 at 2:52 PM Robert Haas wrote: > Code cleanup for toast_fetch_datum and toast_fetch_datum_slice. florican seems unhappy with this. Looking at it now. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company

pgsql: Code cleanup for toast_fetch_datum and toast_fetch_datum_slice.

2019-12-17 Thread Robert Haas
Code cleanup for toast_fetch_datum and toast_fetch_datum_slice. Rework some of the checks for bad TOAST chunks to be a bit simpler and easier to understand. These checks verify that (1) we get all and only the chunk numbers we expect to see and (2) each chunk has the expected size. However, the ex