pgsql: Code review for pg_verify_checksums.c.

2018-08-31 Thread Tom Lane
Code review for pg_verify_checksums.c. Use postgres_fe.h, since this is frontend code. Pretend that we've heard of project style guidelines for, eg, #include order. Use BlockNumber not int arithmetic for block numbers, to avoid misbehavior with relations exceeding 2^31 blocks. Avoid an unnecess

pgsql: Code review for pg_verify_checksums.c.

2018-08-31 Thread Tom Lane
Code review for pg_verify_checksums.c. Use postgres_fe.h, since this is frontend code. Pretend that we've heard of project style guidelines for, eg, #include order. Use BlockNumber not int arithmetic for block numbers, to avoid misbehavior with relations exceeding 2^31 blocks. Avoid an unnecess