Re: pgsql: Collations with nondeterministic comparison

2019-03-26 Thread Tom Lane
Peter Geoghegan writes: > Buildfarm member snapper is still unhappy about this: > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=snapper&dt=2019-03-26%2013%3A01%3A31 Ah, the reason's not so far to seek: Peter only fixed two of the four queries with platform-dependent results. (Could pro

Re: pgsql: Collations with nondeterministic comparison

2019-03-26 Thread Peter Geoghegan
On Mon, Mar 25, 2019 at 12:17 AM Peter Eisentraut wrote: > On 2019-03-25 06:07, Tom Lane wrote: > > Buildfarm member snapper doesn't like this. I think the problem is > > that the queries it's failing on do not bother to constrain their > > output row order. Adding an "EXPLAIN" right there indic

Re: pgsql: Collations with nondeterministic comparison

2019-03-25 Thread Peter Eisentraut
On 2019-03-25 06:07, Tom Lane wrote: > Buildfarm member snapper doesn't like this. I think the problem is > that the queries it's failing on do not bother to constrain their > output row order. Adding an "EXPLAIN" right there indicates that > the INTERSECTs are being done via hashing, meaning tha

Re: pgsql: Collations with nondeterministic comparison

2019-03-24 Thread Tom Lane
Peter Eisentraut writes: > Collations with nondeterministic comparison Buildfarm member snapper doesn't like this. I think the problem is that the queries it's failing on do not bother to constrain their output row order. Adding an "EXPLAIN" right there indicates that the INTERSECTs are being d

Re: pgsql: Collations with nondeterministic comparison

2019-03-22 Thread Christoph Berg
Re: Tom Lane 2019-03-22 <17125.1553282...@sss.pgh.pa.us> > Peter Eisentraut writes: > > Collations with nondeterministic comparison > > Buildfarm member tern doesn't like this patch. I think the issue is > probably that the 012_collation.pl test script isn't being sufficiently > careful to force

Re: pgsql: Collations with nondeterministic comparison

2019-03-22 Thread Tom Lane
Peter Eisentraut writes: > Collations with nondeterministic comparison Buildfarm member tern doesn't like this patch. I think the issue is probably that the 012_collation.pl test script isn't being sufficiently careful to force UTF8 database encoding. regards, tom lane

pgsql: Collations with nondeterministic comparison

2019-03-22 Thread Peter Eisentraut
Collations with nondeterministic comparison This adds a flag "deterministic" to collations. If that is false, such a collation disables various optimizations that assume that strings are equal only if they are byte-wise equal. That then allows use cases such as case-insensitive or accent-insensi