Re: pgsql: Convert debug message from ereport to elog

2018-06-28 Thread Peter Eisentraut
On 6/15/18 06:53, Tatsuo Ishii wrote: > Therefore, elog should be used only for internal errors and low-level > debug logging. Also for these purposes ereport should not be used. ereport() has the advantage that if the debug level excludes the message, then the errmsg() call won't even be run and

Re: pgsql: Convert debug message from ereport to elog

2018-06-14 Thread Tatsuo Ishii
Peter, >> Just out of curiosity, what is the reason why you did this? I guess > > This made a message consistent with an analogous message in > apply_handle_update() earlier in the file. > >> using elog instead of ereport for debugging message is preferable, >> while for non debugging messages

Re: pgsql: Convert debug message from ereport to elog

2018-06-14 Thread Peter Eisentraut
> Just out of curiosity, what is the reason why you did this? I guess This made a message consistent with an analogous message in apply_handle_update() earlier in the file. > using elog instead of ereport for debugging message is preferable, > while for non debugging messages using ereport is pr

Re: pgsql: Convert debug message from ereport to elog

2018-06-12 Thread Tatsuo Ishii
SRA OSS, Inc. Japan English: http://www.sraoss.co.jp/index_en.php Japanese:http://www.sraoss.co.jp From: Peter Eisentraut Subject: pgsql: Convert debug message from ereport to elog Date: Tue, 12 Jun 2018 15:36:49 + Message-ID: > Convert debug message from ereport to elog > &g

pgsql: Convert debug message from ereport to elog

2018-06-12 Thread Peter Eisentraut
Convert debug message from ereport to elog Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/8a07ebb3c172374aa2c83df61c4e05c059511c9a Modified Files -- src/backend/replication/logical/worker.c | 8 1 file changed, 4 insertions(+), 4 deletions(-)