pgsql: Detect format-string mistakes in the libpq_pipeline test module.

2022-09-15 Thread Tom Lane
Detect format-string mistakes in the libpq_pipeline test module. I happened to notice that libpq_pipeline's private implementation of pg_fatal lacked any pg_attribute_printf decoration. Indeed, adding that turned up a mistake! We'd likely never have noticed because the error exits in this code a

pgsql: Detect format-string mistakes in the libpq_pipeline test module.

2022-09-15 Thread Tom Lane
Detect format-string mistakes in the libpq_pipeline test module. I happened to notice that libpq_pipeline's private implementation of pg_fatal lacked any pg_attribute_printf decoration. Indeed, adding that turned up a mistake! We'd likely never have noticed because the error exits in this code a

pgsql: Detect format-string mistakes in the libpq_pipeline test module.

2022-09-15 Thread Tom Lane
Detect format-string mistakes in the libpq_pipeline test module. I happened to notice that libpq_pipeline's private implementation of pg_fatal lacked any pg_attribute_printf decoration. Indeed, adding that turned up a mistake! We'd likely never have noticed because the error exits in this code a