Re: pgsql: Disable run condition optimization for some WindowFuncs

2024-04-30 Thread Tatsuo Ishii
> Thanks for pointing it out. There's not much I can do to correct the > commit message now. Never mind. Thanks for the fix. I am looking forward to seeing the fix for the master branch. Best reagards, -- Tatsuo Ishii SRA OSS LLC English: http://www.sraoss.co.jp/index_en/ Japanese:http://www.sra

Re: pgsql: Disable run condition optimization for some WindowFuncs

2024-04-30 Thread Tom Lane
David Rowley writes: > On Wed, 1 May 2024 at 17:02, Tatsuo Ishii wrote: >> Maybe you are talking about BUG #18305: > Thanks for pointing it out. There's not much I can do to correct the > commit message now. Yeah, once pushed commit messages are pretty much graven on stone tablets. But we do

Re: pgsql: Disable run condition optimization for some WindowFuncs

2024-04-30 Thread David Rowley
On Wed, 1 May 2024 at 17:02, Tatsuo Ishii wrote: > > Bug: #18170 > > Maybe you are talking about BUG #18305: > Unexpected error: "WindowFunc not found in subplan target lists" ? Unsure what happened there, but yes, you're right. That should be #18305 and [1]. I believe I just copied and pasted

Re: pgsql: Disable run condition optimization for some WindowFuncs

2024-04-30 Thread Tatsuo Ishii
> Disable run condition optimization for some WindowFuncs > > 94985c210 added code to detect when WindowFuncs were monotonic and > allowed additional quals to be "pushed down" into the subquery to be > used as WindowClause runConditions in order to short-circuit execution > in nodeWindowAgg.c. >

pgsql: Disable run condition optimization for some WindowFuncs

2024-04-30 Thread David Rowley
Disable run condition optimization for some WindowFuncs 94985c210 added code to detect when WindowFuncs were monotonic and allowed additional quals to be "pushed down" into the subquery to be used as WindowClause runConditions in order to short-circuit execution in nodeWindowAgg.c. The Node repre

pgsql: Disable run condition optimization for some WindowFuncs

2024-04-30 Thread David Rowley
Disable run condition optimization for some WindowFuncs 94985c210 added code to detect when WindowFuncs were monotonic and allowed additional quals to be "pushed down" into the subquery to be used as WindowClause runConditions in order to short-circuit execution in nodeWindowAgg.c. The Node repre