Re: pgsql: Dissociate btequalimage() from interval_ops, ending its deduplic

2023-10-15 Thread Noah Misch
On Sun, Oct 15, 2023 at 05:12:58PM -0400, Tom Lane wrote: > Peter Geoghegan writes: > > On Sat, Oct 14, 2023 at 7:02 PM Tom Lane wrote: > >> Noah Misch writes: > >>> That's right. We don't have a standard that installcheck of v13.N will > >>> have > >>> zero diffs on an initdb from v13.0. > >

Re: pgsql: Dissociate btequalimage() from interval_ops, ending its deduplic

2023-10-15 Thread Tom Lane
Peter Geoghegan writes: > On Sat, Oct 14, 2023 at 7:02 PM Tom Lane wrote: >> Noah Misch writes: >>> That's right. We don't have a standard that installcheck of v13.N will have >>> zero diffs on an initdb from v13.0. >> Um ... don't we? I do not recall very many cases where we changed >> initi

Re: pgsql: Dissociate btequalimage() from interval_ops, ending its deduplic

2023-10-15 Thread Peter Geoghegan
On Sat, Oct 14, 2023 at 7:02 PM Tom Lane wrote: > Noah Misch writes: > > That's right. We don't have a standard that installcheck of v13.N will have > > zero diffs on an initdb from v13.0. > > Um ... don't we? I do not recall very many cases where we changed > initial catalog contents at all in

Re: pgsql: Dissociate btequalimage() from interval_ops, ending its deduplic

2023-10-14 Thread Tom Lane
Noah Misch writes: > On Sat, Oct 14, 2023 at 08:27:58PM -0400, Tom Lane wrote: >> Well, that's indeed going to be a pain for affected people, but >> it doesn't seem like a reason to also break installcheck. > That's right. We don't have a standard that installcheck of v13.N will have > zero diff

Re: pgsql: Dissociate btequalimage() from interval_ops, ending its deduplic

2023-10-14 Thread Noah Misch
On Sat, Oct 14, 2023 at 08:27:58PM -0400, Tom Lane wrote: > Noah Misch writes: > > On Sat, Oct 14, 2023 at 07:45:21PM -0400, Tom Lane wrote: > >> Hmm, I'm not sure that that last is a good idea. The upshot of this > >> (because of the opr_sanity.out change) is that "make installcheck" > >> will f

Re: pgsql: Dissociate btequalimage() from interval_ops, ending its deduplic

2023-10-14 Thread Tom Lane
Noah Misch writes: > On Sat, Oct 14, 2023 at 07:45:21PM -0400, Tom Lane wrote: >> Hmm, I'm not sure that that last is a good idea. The upshot of this >> (because of the opr_sanity.out change) is that "make installcheck" >> will fail against existing back-branch installations. That seems >> more

Re: pgsql: Dissociate btequalimage() from interval_ops, ending its deduplic

2023-10-14 Thread Noah Misch
On Sat, Oct 14, 2023 at 07:45:21PM -0400, Tom Lane wrote: > Noah Misch writes: > > ... This fix makes interval_ops simply omit the support function, > > like numeric_ops does. Back-pack to v13, where btequalimage() first > > appeared. In back branches, for the benefit of old catalog content, > >

Re: pgsql: Dissociate btequalimage() from interval_ops, ending its deduplic

2023-10-14 Thread Tom Lane
Noah Misch writes: > ... This fix makes interval_ops simply omit the support function, > like numeric_ops does. Back-pack to v13, where btequalimage() first > appeared. In back branches, for the benefit of old catalog content, > btequalimage() code will return false for type "interval". Going >

pgsql: Dissociate btequalimage() from interval_ops, ending its deduplic

2023-10-14 Thread Noah Misch
Dissociate btequalimage() from interval_ops, ending its deduplication. Under interval_ops, some equal values are distinguishable. One such pair is '24:00:00' and '1 day'. With that being so, btequalimage() breaches the documented contract for the "equalimage" btree support function. This can ca

pgsql: Dissociate btequalimage() from interval_ops, ending its deduplic

2023-10-14 Thread Noah Misch
Dissociate btequalimage() from interval_ops, ending its deduplication. Under interval_ops, some equal values are distinguishable. One such pair is '24:00:00' and '1 day'. With that being so, btequalimage() breaches the documented contract for the "equalimage" btree support function. This can ca

pgsql: Dissociate btequalimage() from interval_ops, ending its deduplic

2023-10-14 Thread Noah Misch
Dissociate btequalimage() from interval_ops, ending its deduplication. Under interval_ops, some equal values are distinguishable. One such pair is '24:00:00' and '1 day'. With that being so, btequalimage() breaches the documented contract for the "equalimage" btree support function. This can ca

pgsql: Dissociate btequalimage() from interval_ops, ending its deduplic

2023-10-14 Thread Noah Misch
Dissociate btequalimage() from interval_ops, ending its deduplication. Under interval_ops, some equal values are distinguishable. One such pair is '24:00:00' and '1 day'. With that being so, btequalimage() breaches the documented contract for the "equalimage" btree support function. This can ca

pgsql: Dissociate btequalimage() from interval_ops, ending its deduplic

2023-10-14 Thread Noah Misch
Dissociate btequalimage() from interval_ops, ending its deduplication. Under interval_ops, some equal values are distinguishable. One such pair is '24:00:00' and '1 day'. With that being so, btequalimage() breaches the documented contract for the "equalimage" btree support function. This can ca