Re: pgsql: Fix "base" snapshot handling in logical decoding

2018-06-29 Thread Alvaro Herrera
On 2018-Jun-28, Tom Lane wrote: > Alvaro Herrera writes: > > Fix "base" snapshot handling in logical decoding > > According to buildfarm member friarbird, and as confirmed here, > the contrib/test_decoding/specs/oldest_xmin.spec test added by this > commit fails under CLOBBER_CACHE_ALWAYS. Than

Re: pgsql: Fix "base" snapshot handling in logical decoding

2018-06-28 Thread Tom Lane
Alvaro Herrera writes: > Fix "base" snapshot handling in logical decoding According to buildfarm member friarbird, and as confirmed here, the contrib/test_decoding/specs/oldest_xmin.spec test added by this commit fails under CLOBBER_CACHE_ALWAYS. friarbird's error output doesn't seem to be getti

pgsql: Fix "base" snapshot handling in logical decoding

2018-06-26 Thread Alvaro Herrera
Fix "base" snapshot handling in logical decoding Two closely related bugs are fixed. First, xmin of logical slots was advanced too early. During xl_running_xacts processing, xmin of the slot was set to the oldest running xid in the record, but that's wrong: actually, snapshots which will be used

pgsql: Fix "base" snapshot handling in logical decoding

2018-06-26 Thread Alvaro Herrera
Fix "base" snapshot handling in logical decoding Two closely related bugs are fixed. First, xmin of logical slots was advanced too early. During xl_running_xacts processing, xmin of the slot was set to the oldest running xid in the record, but that's wrong: actually, snapshots which will be used

pgsql: Fix "base" snapshot handling in logical decoding

2018-06-26 Thread Alvaro Herrera
Fix "base" snapshot handling in logical decoding Two closely related bugs are fixed. First, xmin of logical slots was advanced too early. During xl_running_xacts processing, xmin of the slot was set to the oldest running xid in the record, but that's wrong: actually, snapshots which will be used

pgsql: Fix "base" snapshot handling in logical decoding

2018-06-26 Thread Alvaro Herrera
Fix "base" snapshot handling in logical decoding Two closely related bugs are fixed. First, xmin of logical slots was advanced too early. During xl_running_xacts processing, xmin of the slot was set to the oldest running xid in the record, but that's wrong: actually, snapshots which will be used

pgsql: Fix "base" snapshot handling in logical decoding

2018-06-26 Thread Alvaro Herrera
Fix "base" snapshot handling in logical decoding Two closely related bugs are fixed. First, xmin of logical slots was advanced too early. During xl_running_xacts processing, xmin of the slot was set to the oldest running xid in the record, but that's wrong: actually, snapshots which will be used