pgsql: Fix comment in copyto.c

2025-11-08 Thread Michael Paquier
Fix comment in copyto.c Author: Tatsuya Kawata Discussion: https://postgr.es/m/cahza6qenbqgmfgdi15dv6e6gwx+8maraqe97owzyz3qpefo...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/9d7e851a2118286f123fd8cfc699e3db9318fba8 Modified Files -

pgsql: Fix comment in pg_get_shmem_allocations_numa()

2025-10-21 Thread Michael Paquier
Fix comment in pg_get_shmem_allocations_numa() The comment fixed in this commit described the function as dealing with database blocks, but in reality it processes shared memory allocations. Author: Bertrand Drouvot Discussion: https://postgr.es/m/[email protected]

pgsql: Fix comment in pg_get_shmem_allocations_numa()

2025-10-21 Thread Michael Paquier
Fix comment in pg_get_shmem_allocations_numa() The comment fixed in this commit described the function as dealing with database blocks, but in reality it processes shared memory allocations. Author: Bertrand Drouvot Discussion: https://postgr.es/m/[email protected]

pgsql: Fix comment in eager_aggregate.sql

2025-10-18 Thread Richard Guo
Fix comment in eager_aggregate.sql The comment stated that eager aggregation is disabled by default, which is no longer true. This patch removes that comment as well as the related GUC set statement. Reported-by: David Rowley Discussion: https://postgr.es/m/caaphdvr4ywpimr3rsgywjwv-u8xorqtakri

pgsql: Fix comment for MAX_SIMUL_LWLOCKS.

2025-08-19 Thread Nathan Bossart
Fix comment for MAX_SIMUL_LWLOCKS. This comment mentions that pg_buffercache locks all buffer partitions simultaneously, but it hasn't done so since v10. Oversight in commit 6e654546fb. Reviewed-by: Andres Freund Discussion: https://postgr.es/m/aKTuAHVEuYCUmmIy%40nathan Branch -- master D

pgsql: Fix comment of tsquerysend()

2025-05-11 Thread Álvaro Herrera
Fix comment of tsquerysend() The comment describes the order in which fields are sent, and it had one of the fields in the wrong place. This has been wrong since e6dbcb72fafa (2008), so backpatch all the way back. Author: Emre Hasegeli Discussion: https://postgr.es/m/CAE2gYzzf38bR_R=izhpmxamqh

pgsql: Fix comment of tsquerysend()

2025-05-11 Thread Álvaro Herrera
Fix comment of tsquerysend() The comment describes the order in which fields are sent, and it had one of the fields in the wrong place. This has been wrong since e6dbcb72fafa (2008), so backpatch all the way back. Author: Emre Hasegeli Discussion: https://postgr.es/m/CAE2gYzzf38bR_R=izhpmxamqh

pgsql: Fix comment of tsquerysend()

2025-05-11 Thread Álvaro Herrera
Fix comment of tsquerysend() The comment describes the order in which fields are sent, and it had one of the fields in the wrong place. This has been wrong since e6dbcb72fafa (2008), so backpatch all the way back. Author: Emre Hasegeli Discussion: https://postgr.es/m/CAE2gYzzf38bR_R=izhpmxamqh

pgsql: Fix comment of tsquerysend()

2025-05-11 Thread Álvaro Herrera
Fix comment of tsquerysend() The comment describes the order in which fields are sent, and it had one of the fields in the wrong place. This has been wrong since e6dbcb72fafa (2008), so backpatch all the way back. Author: Emre Hasegeli Discussion: https://postgr.es/m/CAE2gYzzf38bR_R=izhpmxamqh

pgsql: Fix comment of tsquerysend()

2025-05-11 Thread Álvaro Herrera
Fix comment of tsquerysend() The comment describes the order in which fields are sent, and it had one of the fields in the wrong place. This has been wrong since e6dbcb72fafa (2008), so backpatch all the way back. Author: Emre Hasegeli Discussion: https://postgr.es/m/CAE2gYzzf38bR_R=izhpmxamqh

pgsql: Fix comment of tsquerysend()

2025-05-11 Thread Álvaro Herrera
Fix comment of tsquerysend() The comment describes the order in which fields are sent, and it had one of the fields in the wrong place. This has been wrong since e6dbcb72fafa (2008), so backpatch all the way back. Author: Emre Hasegeli Discussion: https://postgr.es/m/CAE2gYzzf38bR_R=izhpmxamqh

pgsql: Fix comment for MAX_BACKENDS.

2025-02-24 Thread Nathan Bossart
Fix comment for MAX_BACKENDS. This comment mentions that we check that the configured number of backends does not exceed MAX_BACKENDS in RegisterBackgroundWorker() and relevant GUC check hooks, neither of which has those checks anymore. To fix, adjust this comment to say that we do the check in I

pgsql: Fix comment of StrategySyncStart()

2025-01-30 Thread Michael Paquier
Fix comment of StrategySyncStart() The top comment of StrategySyncStart() mentions BufferSync(), but this function calls BgBufferSync(), not BufferSync(). Oversight in 9cd00c457e6a. Author: Ashutosh Bapat Discussion: https://postgr.es/m/[email protected]

pgsql: Fix comment of StrategySyncStart()

2025-01-30 Thread Michael Paquier
Fix comment of StrategySyncStart() The top comment of StrategySyncStart() mentions BufferSync(), but this function calls BgBufferSync(), not BufferSync(). Oversight in 9cd00c457e6a. Author: Ashutosh Bapat Discussion: https://postgr.es/m/[email protected]

pgsql: Fix comment of StrategySyncStart()

2025-01-30 Thread Michael Paquier
Fix comment of StrategySyncStart() The top comment of StrategySyncStart() mentions BufferSync(), but this function calls BgBufferSync(), not BufferSync(). Oversight in 9cd00c457e6a. Author: Ashutosh Bapat Discussion: https://postgr.es/m/[email protected]

pgsql: Fix comment of StrategySyncStart()

2025-01-30 Thread Michael Paquier
Fix comment of StrategySyncStart() The top comment of StrategySyncStart() mentions BufferSync(), but this function calls BgBufferSync(), not BufferSync(). Oversight in 9cd00c457e6a. Author: Ashutosh Bapat Discussion: https://postgr.es/m/[email protected]

pgsql: Fix comment of StrategySyncStart()

2025-01-30 Thread Michael Paquier
Fix comment of StrategySyncStart() The top comment of StrategySyncStart() mentions BufferSync(), but this function calls BgBufferSync(), not BufferSync(). Oversight in 9cd00c457e6a. Author: Ashutosh Bapat Discussion: https://postgr.es/m/[email protected]

pgsql: Fix comment of StrategySyncStart()

2025-01-30 Thread Michael Paquier
Fix comment of StrategySyncStart() The top comment of StrategySyncStart() mentions BufferSync(), but this function calls BgBufferSync(), not BufferSync(). Oversight in 9cd00c457e6a. Author: Ashutosh Bapat Discussion: https://postgr.es/m/[email protected]

pgsql: Fix comment about AVX-512 popcount support.

2025-01-22 Thread Nathan Bossart
Fix comment about AVX-512 popcount support. Since commit f78667bd91, we've used __attribute__((target(...))) instead of extra compiler flags for AVX-512 support, but this comment still says that we put the code in a separate file because it might require extra compiler flags. Let's just remove th

pgsql: Fix comment in injection_point.c

2024-11-12 Thread Michael Paquier
Fix comment in injection_point.c InjectionPointEntry->name was described as a hash key, which was fine when introduced in d86d20f0ba79, but it is not now. Oversight in 86db52a5062a, that has changed the way injection points are stored in shared memory from a hash table to an array. Backpatch-thr

pgsql: Fix comment in injection_point.c

2024-11-12 Thread Michael Paquier
Fix comment in injection_point.c InjectionPointEntry->name was described as a hash key, which was fine when introduced in d86d20f0ba79, but it is not now. Oversight in 86db52a5062a, that has changed the way injection points are stored in shared memory from a hash table to an array. Backpatch-thr

pgsql: Fix comment in LockReleaseAll() on when locallock->nLock can be

2024-11-04 Thread Heikki Linnakangas
Fix comment in LockReleaseAll() on when locallock->nLock can be zero We reach this case also e.g. when a deadlock is detected, not only when we run out of memory. Reviewed-by: Maxim Orlov Discussion: https://www.postgresql.org/message-id/[email protected] Branch --

pgsql: Fix comment about pg_authid.

2024-10-19 Thread Tom Lane
Fix comment about pg_authid. pg_shadow is not "publicly readable". (pg_group is, but there seems no need to make that distinction here.) Seems to be a thinko dating clear back to 7762619e9. Antonin Houska Discussion: https://postgr.es/m/31926.1729252247@antos Branch -- master Details ---

pgsql: Fix comment on processes being kept over a restart

2024-08-09 Thread Heikki Linnakangas
Fix comment on processes being kept over a restart All child processes except the syslogger are killed on a restart. The archiver might be already running though, if it was started during recovery. The split in the comments between "other special children" and the first group of "background tasks

pgsql: Fix comment in libpqrcv_check_conninfo().

2024-07-09 Thread Fujii Masao
Fix comment in libpqrcv_check_conninfo(). Previously, the comment incorrectly stated that libpqrcv_check_conninfo() returns true or false based on the connection string check. However, this function actually has a void return type and raises an error if the check fails. Author: Rintaro Ikeda Revi

pgsql: Fix comment in pg_upgrade.h.

2024-06-19 Thread Nathan Bossart
Fix comment in pg_upgrade.h. Contrary to what the comment for the "check" struct member claims, 'pg_upgrade --check' performs only the checks and does not ask the user for permission to make changes. Reviewed-by: Daniel Gustafsson Discussion: https://postgr.es/m/ZnHk7ci5IuTWVc_c%40nathan Branch

pgsql: Fix comment about cross-checking the varnullingrels

2024-06-09 Thread Richard Guo
Fix comment about cross-checking the varnullingrels The nullingrels match checks are not limited to debugging builds. Oversight in commit 867be9c07. Author: Richard Guo Reviewed-by: Alvaro Herrera, Tom Lane, Robert Haas Discussion: https://postgr.es/m/CAMbWs4_SDsdYD7DdQw7RXc3jv3axbg+RGZ7aSi9GaqX

pgsql: Fix comment in 024_add_drop_pub.pl

2024-05-23 Thread Michael Paquier
Fix comment in 024_add_drop_pub.pl A comment of the test was referring to an incorrect table. Thinko in 1046a69b3087. Extracted from a larger patch by the same author. Author: Alexander Lakhin Discussion: https://postgr.es/m/[email protected] Branch -- master

pgsql: Fix comment regarding LibreSSL availability

2024-05-05 Thread Daniel Gustafsson
Fix comment regarding LibreSSL availability SSL_AD_NO_APPLICATION_PROTOCOL is indeed available in LibreSSL, but only in 3.4.3 and later (shipped in OpenBSD 7.0). Discussion: https://postgr.es/m/[email protected] Branch -- master Details --- https://git.postgresql.

pgsql: Fix comment thinko in sequence.c

2024-02-26 Thread Michael Paquier
Fix comment thinko in sequence.c One comment mentioned indexes, but the relation opened should be sequences. Reported-by: Matthias van de Meent Discussion: https://postgr.es/m/CAEze2WiMGNG9XK3NSUen-5BARhCnP=u=fxnf8pvpl2qdkeo...@mail.gmail.com Branch -- master Details --- https://git.po

pgsql: Fix comment in index.c

2024-01-25 Thread Michael Paquier
Fix comment in index.c Extracted from a larger patch by the same author. Author: Gurjeet Singh Discussion: https://postgr.es/m/CABwTF4WX=m5pQvKXvLFJoEH=hSd6O=iZSqxVqHKjFm+iL-AO=w...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/bd5760df38c0032bb94

pgsql: Fix comment on gist_stratnum_btree

2024-01-24 Thread Peter Eisentraut
Fix comment on gist_stratnum_btree We give results for <, <=, =, >=, and >, not just =. Because why not? Author: Paul A. Jungwirth Discussion: https://www.postgresql.org/message-id/flat/CA+renyUApHgSZF9-nd-a0+OPGharLQLO=mdhcy4_qq0+noc...@mail.gmail.com Branch -- master Details --- htt

pgsql: Fix comment about ressortgrouprefs being unique in setop plans.

2023-11-28 Thread Heikki Linnakangas
Fix comment about ressortgrouprefs being unique in setop plans. Author: Richard Guo, Tom Lane Discussion: https://www.postgresql.org/message-id/CAMbWs49rAfFS-yd7=QxtDUrZDFfRBGy4rGBJNyGDH7=clip...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/10a599

pgsql: Fix comment in tableam.h about GetHeapamTableAmRoutine()

2023-11-27 Thread Michael Paquier
Fix comment in tableam.h about GetHeapamTableAmRoutine() This routine is located in heapam_handler.c, not tableamapi.c. Issue noted while hacking the area for a different patch. Reviewed-by: Richard Guo Discussion: https://postgr.es/m/[email protected] Branch -- master Details -

pgsql: Fix comment from commit 22655aa231.

2023-10-15 Thread Thomas Munro
Fix comment from commit 22655aa231. Per automated complaint from BF animal koel this needed to be re-indented, but there was also a typo. Back-patch to 16. Branch -- REL_16_STABLE Details --- https://git.postgresql.org/pg/commitdiff/3090213690bd69dd46dae865a2021982e7309208 Modified Fil

pgsql: Fix comment from commit 22655aa231.

2023-10-15 Thread Thomas Munro
Fix comment from commit 22655aa231. Per automated complaint from BF animal koel this needed to be re-indented, but there was also a typo. Back-patch to 16. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/01529c7040088db2718628d0814058598152bd39 Modified Files

pgsql: Fix comment of PQputCopyEnd()

2023-08-29 Thread Michael Paquier
Fix comment of PQputCopyEnd() The comment describing the error codes of this routine mentioned 0 as a possible value, but this error code has never been used. Author: Junwang Zhao Reviewed-by: Aleksander Alekseev Discussion: https://postgr.es/m/CAEG8a3Jt5KwMNr+_S6VN68rog4HeoG6ELvPQO8kZNQTeJeQ=r.

pgsql: Fix comment on clearing padding.

2023-06-27 Thread Heikki Linnakangas
Fix comment on clearing padding. Author: Japin Li Discussion: https://www.postgresql.org/message-id/meyp282mb16696317b5da7d0d92306149b6...@meyp282mb1669.ausp282.prod.outlook.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/876d17d62fe84d706058f2458f067f0e9049a23

pgsql: Fix comment on clearing padding.

2023-06-27 Thread Heikki Linnakangas
Fix comment on clearing padding. Author: Japin Li Discussion: https://www.postgresql.org/message-id/meyp282mb16696317b5da7d0d92306149b6...@meyp282mb1669.ausp282.prod.outlook.com Branch -- REL_14_STABLE Details --- https://git.postgresql.org/pg/commitdiff/0c3fb8ac5f17d19a1d9df24594050dcf

pgsql: Fix comment on clearing padding.

2023-06-27 Thread Heikki Linnakangas
Fix comment on clearing padding. Author: Japin Li Discussion: https://www.postgresql.org/message-id/meyp282mb16696317b5da7d0d92306149b6...@meyp282mb1669.ausp282.prod.outlook.com Branch -- REL_15_STABLE Details --- https://git.postgresql.org/pg/commitdiff/596177a9222f5a093679fe6ac0587644

pgsql: Fix comment indentation and whitespace

2023-02-24 Thread Peter Eisentraut
Fix comment indentation and whitespace The previous layout satisfied pgindent but failed the git whitespace check. Fix by not putting the comment first in the line, which pgindent does not handle well. Discussion: https://www.postgresql.org/message-id/flat/480e3c67-b703-46ff-a418-d3b481d68372%4

pgsql: Fix comment that was missing a word.

2022-12-19 Thread Robert Haas
Fix comment that was missing a word. Ted Yu Discussion: http://postgr.es/m/CALte62wkFB05=RTWf7BL_6MfWs2=DY=ai-k7lwn_+0tjuup...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/eb60eb08a95eb531f3f2a459c1b623c5ac37ecd3 Modified Files -- sr

pgsql: Fix comment in fe-auth-scram.c

2022-11-29 Thread Michael Paquier
Fix comment in fe-auth-scram.c The frontend-side routine in charge of building a SCRAM verifier mentioned that the restrictions applying to SASLprep on the password with the encoding are described at the top of fe-auth-scram.c, but this information is in auth-scram.c. This is wrong since 8f8b9be,

pgsql: Fix comment in fe-auth-scram.c

2022-11-29 Thread Michael Paquier
Fix comment in fe-auth-scram.c The frontend-side routine in charge of building a SCRAM verifier mentioned that the restrictions applying to SASLprep on the password with the encoding are described at the top of fe-auth-scram.c, but this information is in auth-scram.c. This is wrong since 8f8b9be,

pgsql: Fix comment in fe-auth-scram.c

2022-11-29 Thread Michael Paquier
Fix comment in fe-auth-scram.c The frontend-side routine in charge of building a SCRAM verifier mentioned that the restrictions applying to SASLprep on the password with the encoding are described at the top of fe-auth-scram.c, but this information is in auth-scram.c. This is wrong since 8f8b9be,

pgsql: Fix comment in fe-auth-scram.c

2022-11-29 Thread Michael Paquier
Fix comment in fe-auth-scram.c The frontend-side routine in charge of building a SCRAM verifier mentioned that the restrictions applying to SASLprep on the password with the encoding are described at the top of fe-auth-scram.c, but this information is in auth-scram.c. This is wrong since 8f8b9be,

pgsql: Fix comment in fe-auth-scram.c

2022-11-29 Thread Michael Paquier
Fix comment in fe-auth-scram.c The frontend-side routine in charge of building a SCRAM verifier mentioned that the restrictions applying to SASLprep on the password with the encoding are described at the top of fe-auth-scram.c, but this information is in auth-scram.c. This is wrong since 8f8b9be,

pgsql: Fix comment in fe-auth-scram.c

2022-11-29 Thread Michael Paquier
Fix comment in fe-auth-scram.c The frontend-side routine in charge of building a SCRAM verifier mentioned that the restrictions applying to SASLprep on the password with the encoding are described at the top of fe-auth-scram.c, but this information is in auth-scram.c. This is wrong since 8f8b9be,

pgsql: Fix comment in snapbuild.c

2022-11-28 Thread Michael Paquier
Fix comment in snapbuild.c Author: Masahiko Sawada Discussion: https://postgr.es/m/cad21aoamf-pksnmgajg2dtghp7o7vphoexcxfqlkzg8xrbr...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/8aa03f3caaed9dd438a20c3423daa43a44549d60 Modified Files --

pgsql: Fix comment of SimpleLruInit() in slru.c

2022-11-09 Thread Michael Paquier
Fix comment of SimpleLruInit() in slru.c sync_handler was not mentioned in the comment block of the function. Oversight in dee663f. Author: Aleksander Alekseev Discussion: https://postgr.es/m/CAJ7c6TPUd9BwNY47TtMxaijLHSbyHNdhu=kvbgnvo_bi+oc...@mail.gmail.com Backpatch-through: 14 Branch --

pgsql: Fix comment of SimpleLruInit() in slru.c

2022-11-09 Thread Michael Paquier
Fix comment of SimpleLruInit() in slru.c sync_handler was not mentioned in the comment block of the function. Oversight in dee663f. Author: Aleksander Alekseev Discussion: https://postgr.es/m/CAJ7c6TPUd9BwNY47TtMxaijLHSbyHNdhu=kvbgnvo_bi+oc...@mail.gmail.com Backpatch-through: 14 Branch --

pgsql: Fix comment of SimpleLruInit() in slru.c

2022-11-09 Thread Michael Paquier
Fix comment of SimpleLruInit() in slru.c sync_handler was not mentioned in the comment block of the function. Oversight in dee663f. Author: Aleksander Alekseev Discussion: https://postgr.es/m/CAJ7c6TPUd9BwNY47TtMxaijLHSbyHNdhu=kvbgnvo_bi+oc...@mail.gmail.com Backpatch-through: 14 Branch --

pgsql: Fix comment in xlogprefetcher.c

2022-10-06 Thread Michael Paquier
Fix comment in xlogprefetcher.c Author: Sho Kato Discussion: https://postgr.es/m/tycpr01mb684954052ec534a3261b29249f...@tycpr01mb6849.jpnprd01.prod.outlook.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/5757141caeaff4af0c206ab672d542cbd608542c Modified Files

pgsql: Fix comment in guc_tables.c

2022-10-03 Thread Michael Paquier
Fix comment in guc_tables.c s/ERROR_HANDLING/ERROR_HANDLING_OPTIONS/. Author: Peter Smith Discussion: https://postgr.es/m/cahut+ptdj3cv+f0pvisc0xymi2lhgbpqxqwtf0fjisvn_nv...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/bdf9b60085bca2dbb0af920d50f

pgsql: Fix comment in walsender_private.h

2022-08-21 Thread Michael Paquier
Fix comment in walsender_private.h All the members of the stucture are protected by the spinlock WalSnd, but a comment referred to "replyTime" and "latch" as not being in the set of what gets protected, contrary to what walsender.c does. Author: Bharath Rupireddy Discussion: https://postgr.es/m/

pgsql: Fix comment in copyfrom_internal.h

2022-08-06 Thread Michael Paquier
Fix comment in copyfrom_internal.h COPY_NEW_FE has become COPY_FRONTEND in 3174d69, that has removed the frontend-backend protocol v2. Author: Zhang Mingli Discussion: https://postgr.es/m/aeec12a3-501e-449a-8d25-901c4ff706cf@Spark Branch -- master Details --- https://git.postgresql.org/

pgsql: Fix comment in pg_db_role_setting.h

2022-08-01 Thread John Naylor
Fix comment in pg_db_role_setting.h Noted by Japin Li Discussion: https://www.postgresql.org/message-id/MEYP282MB16691ACEDBC94161CF4BA1CCB69A9%40MEYP282MB1669.AUSP282.PROD.OUTLOOK.COM Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/c689baa158bbe76597b4dacd61c415b5

pgsql: Fix comment in procarray.c.

2022-07-27 Thread Fujii Masao
Fix comment in procarray.c. Commit fea10a6434 renamed VariableCacheData.nextFullXid to nextXid. But commit dc7420c2c9 introduced the comment mentioning nextFullXid. This commit changes"nextFullXid" to "nextXid" in the comment. Author: Zhang Mingli Discussion: https://postgr.es/m/642ba615-4b28-4b0

pgsql: Fix comment in regression tests for large objects

2022-06-16 Thread Michael Paquier
Fix comment in regression tests for large objects The values assigned to INV_WRITE and INV_READ were reversed in the tests, which would be confusing when writing tests specific to read or write operations on LOs. Author: Yugo Nagata Discussion: https://postgr.es/m/20220527153028.61a4608f66abcd02

pgsql: Fix comment in pg_proc.c

2022-05-13 Thread Michael Paquier
Fix comment in pg_proc.c pgstat_create_function() creates stats for a function in a transactional fashion, so the stats would be dropped if transaction creating the function is aborted, not committed. Author: Amul Sul Discussion: https://postgr.es/m/caaj_b97x1t3xgamwnj4w7ksgn0ntug-vlrqj4nb-dsnr0

pgsql: Fix comment typo in PotsgreSQL::Test::Cluster module

2022-03-31 Thread Andrew Dunstan
Fix comment typo in PotsgreSQL::Test::Cluster module Per Dagfinn Ilmari Mannsåker Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/ddee016b342cddcfb97325afac0a65c502932e5f Modified Files -- src/test/perl/PostgreSQL/Test/Cluster.pm | 2 +- 1 file changed,

pgsql: Fix comment in execParallel.c

2022-03-27 Thread Michael Paquier
Fix comment in execParallel.c 0f61727 has made this comment incorrect. Author: Julien Rouhaud Reviewed-by: Matthias van de Meent Discussion: https://postgr.es/m/20220326160117.qtp5nkuku6cvhcby@jrouhaud Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/411b91360f2711e

pgsql: Fix comment in CheckIndexCompatible().

2022-02-17 Thread Fujii Masao
Fix comment in CheckIndexCompatible(). Commit 5f173040 removed the parameter "heapRelation" from CheckIndexCompatible(), but forgot to remove the mention of it from the comment. This commit removes that unnecessary mention. Also this commit adds the missing mention of the parameter "oldId" in the

pgsql: Fix comment related to pg_cryptohash_error()

2022-01-11 Thread Michael Paquier
Fix comment related to pg_cryptohash_error() One of the comments introduced in b69aba7 was worded a bit weirdly, so improve it. Reported-by: Sergey Shinderuk Discussion: https://postgr.es/m/[email protected] Backpatch-through: 14 Branch -- master Details -

pgsql: Fix comment related to pg_cryptohash_error()

2022-01-11 Thread Michael Paquier
Fix comment related to pg_cryptohash_error() One of the comments introduced in b69aba7 was worded a bit weirdly, so improve it. Reported-by: Sergey Shinderuk Discussion: https://postgr.es/m/[email protected] Backpatch-through: 14 Branch -- REL_14_STABLE De

pgsql: Fix comment in fe-connect.c about PQping and pg_ctl

2022-01-06 Thread Michael Paquier
Fix comment in fe-connect.c about PQping and pg_ctl Since f13ea95f, pg_ctl does not use PQping(), but one comment did not get the call. Author: Euler Taveira Discussion: https://postgr.es/m/[email protected] Branch -- master Details --- https://git.p

pgsql: Fix comment grammar in slotfuncs.c

2021-12-01 Thread Michael Paquier
Fix comment grammar in slotfuncs.c Author: Bharath Rupireddy Discussion: https://postgr.es/m/calj2acukrnr2xtak+qaqxotjpkgn8zxwripv7sr27t+q5qf...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/7799d4e3bdd14c90989d829a9b24e73d4ff4d4ad Modified Files

pgsql: Fix comment in parsenodes.h

2021-03-30 Thread Michael Paquier
Fix comment in parsenodes.h CreateStmt->inhRelations is a list of RangeVars, but a comment was incorrect about that. Author: Julien Rouhaud Discussion: https://postgr.es/m/20210330123015.yzekhz5sweqbgxdr@nol Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/7ef64e7e7

pgsql: Fix comment in indexing.c

2021-03-17 Thread Michael Paquier
Fix comment in indexing.c 578b229, that removed support for WITH OIDS, has changed CatalogTupleInsert() to not return an Oid, but one comment was still mentioning that. Author: Vik Fearing Discussion: https://postgr.es/m/[email protected] Branch -- mas

pgsql: Fix comment about promising tuples.

2021-03-16 Thread Peter Geoghegan
Fix comment about promising tuples. Oversight in commit d168b666823, which added bottom-up index deletion. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/fbe4cb3bd49f9e524f53ef77c775c1bad4d0312a Modified Files -- src/backend/access/heap/heapam.c | 6 ++

pgsql: Fix comment in procarray.c

2020-08-27 Thread Michael Paquier
Fix comment in procarray.c The description of GlobalVisDataRels was missing, GlobalVisCatalogRels being mentioned instead. Author: Jim Nasby Discussion: https://postgr.es/m/[email protected] Branch -- master Details --- https://git.postgresql.org/pg/commitd

pgsql: Fix comment in instrument.h

2020-07-30 Thread Michael Paquier
Fix comment in instrument.h local_blks_dirtied tracks the number of local blocks dirtied, not shared ones. Author: Kirk Jamison Discussion: https://postgr.es/m/osbpr01mb2341760686dc056de89d2ab9ef...@osbpr01mb2341.jpnprd01.prod.outlook.com Branch -- master Details --- https://git.postgr

pgsql: Fix comment in sha2.h

2020-07-21 Thread Michael Paquier
Fix comment in sha2.h An incorrect reference to SHA-1 was present. Author: Daniel Gustafsson Discussion: https://postgr.es/m/[email protected] Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/e47c2602aa4d35a4e3eb6ada40454c6c0f1279bf Modi

pgsql: Fix comment in heap.c

2020-06-23 Thread Michael Paquier
Fix comment in heap.c The description of InsertPgAttributeTuple() does not match its handling of pg_attribute contents with NULL values for a long time, with 911e702 making things more inconsistent. This adjusts the description to match the reality. Author: Daniel Gustafsson Discussion: https://

pgsql: Fix comment in be-secure-openssl.c

2020-06-03 Thread Michael Paquier
Fix comment in be-secure-openssl.c Since 573bd08, hardcoded DH parameters have been moved to a different file, making the comment on top of load_dh_buffer() incorrect. Author: Daniel Gustafsson Discussion: https://postgr.es/m/[email protected] Branch -- master De

pgsql: Fix comment in slot.c.

2020-05-17 Thread Amit Kapila
Fix comment in slot.c. Reported-by: Sawada Masahiko Author: Sawada Masahiko Reviewed-by: Amit Kapila Backpatch-through: 9.5 Discussion: https://postgr.es/m/ca+fd4k4ws7m7yq8pqsym5wb1y75dzebtd1szjuqdfe0kjq-...@mail.gmail.com Branch -- REL_12_STABLE Details --- https://git.postgresql.org/p

pgsql: Fix comment in slot.c.

2020-05-17 Thread Amit Kapila
Fix comment in slot.c. Reported-by: Sawada Masahiko Author: Sawada Masahiko Reviewed-by: Amit Kapila Backpatch-through: 9.5 Discussion: https://postgr.es/m/ca+fd4k4ws7m7yq8pqsym5wb1y75dzebtd1szjuqdfe0kjq-...@mail.gmail.com Branch -- REL_11_STABLE Details --- https://git.postgresql.org/p

pgsql: Fix comment in slot.c.

2020-05-17 Thread Amit Kapila
Fix comment in slot.c. Reported-by: Sawada Masahiko Author: Sawada Masahiko Reviewed-by: Amit Kapila Backpatch-through: 9.5 Discussion: https://postgr.es/m/ca+fd4k4ws7m7yq8pqsym5wb1y75dzebtd1szjuqdfe0kjq-...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commi

pgsql: Fix comment in slot.c.

2020-05-17 Thread Amit Kapila
Fix comment in slot.c. Reported-by: Sawada Masahiko Author: Sawada Masahiko Reviewed-by: Amit Kapila Backpatch-through: 9.5 Discussion: https://postgr.es/m/ca+fd4k4ws7m7yq8pqsym5wb1y75dzebtd1szjuqdfe0kjq-...@mail.gmail.com Branch -- REL_10_STABLE Details --- https://git.postgresql.org/p

pgsql: Fix comment in slot.c.

2020-05-17 Thread Amit Kapila
Fix comment in slot.c. Reported-by: Sawada Masahiko Author: Sawada Masahiko Reviewed-by: Amit Kapila Backpatch-through: 9.5 Discussion: https://postgr.es/m/ca+fd4k4ws7m7yq8pqsym5wb1y75dzebtd1szjuqdfe0kjq-...@mail.gmail.com Branch -- REL9_5_STABLE Details --- https://git.postgresql.org/p

pgsql: Fix comment in slot.c.

2020-05-17 Thread Amit Kapila
Fix comment in slot.c. Reported-by: Sawada Masahiko Author: Sawada Masahiko Reviewed-by: Amit Kapila Backpatch-through: 9.5 Discussion: https://postgr.es/m/ca+fd4k4ws7m7yq8pqsym5wb1y75dzebtd1szjuqdfe0kjq-...@mail.gmail.com Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/p

pgsql: Fix comment in xlogutils.c

2020-05-11 Thread Michael Paquier
Fix comment in xlogutils.c The existing callers of XLogReadDetermineTimeline() performing recovery need to check a replay LSN position when determining on which timeline to read a WAL page. A portion of the comment describing this function said exactly that, while referring to a routine for fetch

pgsql: Fix comment related to concurrent index swapping in index.c

2020-03-18 Thread Michael Paquier
Fix comment related to concurrent index swapping in index.c A comment about switching indisvalid of the new and old indexes swapped in REINDEX CONCURRENTLY got this backwards. Issue introduced by 5dc92b8, the original commit of REINDEX CONCURRENTLY. Author: Julien Rouhaud Discussion: https://pos

pgsql: Fix comment related to concurrent index swapping in index.c

2020-03-18 Thread Michael Paquier
Fix comment related to concurrent index swapping in index.c A comment about switching indisvalid of the new and old indexes swapped in REINDEX CONCURRENTLY got this backwards. Issue introduced by 5dc92b8, the original commit of REINDEX CONCURRENTLY. Author: Julien Rouhaud Discussion: https://pos

pgsql: Fix comment in xlog.c.

2020-03-16 Thread Fujii Masao
Fix comment in xlog.c. This commit fixes the comment about SharedHotStandbyActive variable. The comment was apparently copy-and-pasted. Author: Atsushi Torikoshi Discussion: https://postgr.es/m/cacz0uyejpqzb9wn2rwc_rmvdybyyqdbkpudr1nyxjg4f9yg...@mail.gmail.com Branch -- master Details

pgsql: Fix comment in heapam.c

2020-01-13 Thread Michael Paquier
Fix comment in heapam.c Improvement per suggestion from Tom Lane. Author: Daniel Gustafsson Discussion: https://postgr.es/m/[email protected] Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/7689d907bbb177fa2a8f5aca3f968761dd16bf28 Modif

pgsql: Fix comment in test

2020-01-02 Thread Peter Eisentraut
Fix comment in test The comment was apparently copy-and-pasted and did not reflect the actual test outcome. Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/f5cdf4629f7862ae081cb0357a014a3af2643bf1 Modified Files -- src/test/regress/expected/alter

pgsql: Fix comment in test

2020-01-02 Thread Peter Eisentraut
Fix comment in test The comment was apparently copy-and-pasted and did not reflect the actual test outcome. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/198c7153dccb11950e3030dec564fdc6e59b4451 Modified Files -- src/test/regress/expected/alter_generi

pgsql: Fix comment in test

2020-01-02 Thread Peter Eisentraut
Fix comment in test The comment was apparently copy-and-pasted and did not reflect the actual test outcome. Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/f565f530edcc4728ed004b7c75b876168df2daa0 Modified Files -- src/test/regress/expected/alter

pgsql: Fix comment in test

2020-01-02 Thread Peter Eisentraut
Fix comment in test The comment was apparently copy-and-pasted and did not reflect the actual test outcome. Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/98b75c38c6ed2701c278316daac744222a1d56dd Modified Files -- src/test/regress/expected/alter

pgsql: Fix comment in xact.h

2019-11-20 Thread Michael Paquier
Fix comment in xact.h xl_xact_relfilenodes refers to a number of relations, not XIDs, whose relfilenodes are processed. Author: Yu Kimura Discussion: https://postgr.es/m/[email protected] Branch -- master Details --- https://git.postgresql.org/pg/commitdif

pgsql: Fix comment

2019-10-22 Thread Peter Eisentraut
Fix comment The last argument of smgrextend() was renamed from isTemp to skipFsync in debcec7dc31a992703911a9953e299c8d730c778, but the comments at two call sites were not updated. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/f86f46d091a6876fbf28e0a4a87ca72b560cf

pgsql: Fix comment in xlogreader.c

2019-09-25 Thread Michael Paquier
Fix comment in xlogreader.c This has been introduced by 709d003, that has moved readSegNo, readOff and readPageTLI into a new structure called WALOpenSegment initialized separately. Author: Kyotaro Horiguchi Discussion: https://postgr.es/m/[email protected] Branc

pgsql: Fix comment in psql's describe.c

2019-09-10 Thread Michael Paquier
Fix comment in psql's describe.c Procedures are supported since v11 and \dfp can be used since this version, but it was not mentioned as a supported option in the description of describeFunctions() which handles \df in psql. Extracted from a larger patch. Author: Fabien Coelho Discussion: https:

pgsql: Fix comment

2019-05-28 Thread Peter Eisentraut
Fix comment This code block was copied/adapted from other similar places but somehow the comment placement was changed so that it makes less sense. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/a94fd139df975a006d1697d2a7180d3656222d4d Modified Files -

pgsql: Fix comment for issue_xlog_fsync().

2019-05-20 Thread Fujii Masao
Fix comment for issue_xlog_fsync(). "segno" is the argument for the function, not "log" and "seg". Author: Antonin Houska Discussion: https://postgr.es/m/[email protected] Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/b8e2170e40a151eb94079ce9cd791a712ed9

pgsql: Fix comment on when HOT update is possible.

2019-05-14 Thread Heikki Linnakangas
Fix comment on when HOT update is possible. The conditions listed in this comment have changed several times, and at some point the thing that the "if so" referred to was negated. The text was OK up to 9.6. It was differently wrong in v10, v11 and master, so fix in all those versions. Branch ---

pgsql: Fix comment on when HOT update is possible.

2019-05-14 Thread Heikki Linnakangas
Fix comment on when HOT update is possible. The conditions listed in this comment have changed several times, and at some point the thing that the "if so" referred to was negated. The text was OK up to 9.6. It was differently wrong in v10, v11 and master, so fix in all those versions. Branch ---

pgsql: Fix comment on when HOT update is possible.

2019-05-14 Thread Heikki Linnakangas
Fix comment on when HOT update is possible. The conditions listed in this comment have changed several times, and at some point the thing that the "if so" referred to was negated. The text was OK up to 9.6. It was differently wrong in v10, v11 and master, so fix in all those versions. Branch ---

pgsql: Fix comment related to calculation location of total_table_pages

2019-02-12 Thread Michael Paquier
Fix comment related to calculation location of total_table_pages As of commit c6e4133, the calculation happens in make_one_rel() and not query_planner(). Author: Amit Langote Discussion: https://postgr.es/m/[email protected] Branch -- master Details ---

  1   2   >