Re: pgsql: Fix declaration after statement

2019-04-11 Thread Alvaro Herrera
On 2019-Apr-11, Tom Lane wrote: > Alvaro Herrera writes: > > (My compiler does not complain about it, even though > > -Wdeclaration-after-statement is specified. Weird.) > > longfin's compiler doesn't either (clang-1001.0.46.3). > What are you using? Maybe we should be filing bug reports? gcc

Re: pgsql: Fix declaration after statement

2019-04-10 Thread Thomas Munro
On Thu, Apr 11, 2019 at 5:05 PM Tom Lane wrote: > Alvaro Herrera writes: > > (My compiler does not complain about it, even though > > -Wdeclaration-after-statement is specified. Weird.) > > longfin's compiler doesn't either (clang-1001.0.46.3). > What are you using? Maybe we should be filing bu

Re: pgsql: Fix declaration after statement

2019-04-10 Thread Tom Lane
Alvaro Herrera writes: > (My compiler does not complain about it, even though > -Wdeclaration-after-statement is specified. Weird.) longfin's compiler doesn't either (clang-1001.0.46.3). What are you using? Maybe we should be filing bug reports? regards, tom lane

pgsql: Fix declaration after statement

2019-04-10 Thread Alvaro Herrera
Fix declaration after statement This style is frowned upon. I inadvertently introduced one in commit fe0e0b4fc7f0. (My compiler does not complain about it, even though -Wdeclaration-after-statement is specified. Weird.) Author: Masahiko Sawada Branch -- master Details --- https://git