Re: pgsql: Fix incidental warnings from cpluspluscheck.

2019-08-18 Thread Tom Lane
Thomas Munro writes: > On Mon, Aug 19, 2019 at 11:01 AM Tom Lane wrote: >> Remove use of "register" keyword in hashfn.c. It's obsolescent >> according to recent C++ compilers, and no modern C compiler pays >> much attention to it either. > We have some more of those: > src/backend/regex/regexe

Re: pgsql: Fix incidental warnings from cpluspluscheck.

2019-08-18 Thread Thomas Munro
On Mon, Aug 19, 2019 at 11:01 AM Tom Lane wrote: > Remove use of "register" keyword in hashfn.c. It's obsolescent > according to recent C++ compilers, and no modern C compiler pays > much attention to it either. We have some more of those: src/backend/regex/regexec.c src/common/md5.c src/includ

pgsql: Fix incidental warnings from cpluspluscheck.

2019-08-18 Thread Tom Lane
Fix incidental warnings from cpluspluscheck. Remove use of "register" keyword in hashfn.c. It's obsolescent according to recent C++ compilers, and no modern C compiler pays much attention to it either. Also fix one cosmetic warning about signed vs unsigned comparison. Discussion: https://postgr