Fix memory leak in _gin_parallel_merge To insert the merged GIN entries in _gin_parallel_merge, the leader calls ginEntryInsert(). This may allocate memory, e.g. for a new leaf tuple. This was allocated in the PortalContext, and kept until the end of the index build. For most GIN indexes the amount of leaked memory is negligible, but for custom opclasses with large keys it may cause OOMs.
Fixed by calling ginEntryInsert() in a temporary memory context, reset after each insert. Other ginEntryInsert() callers do this too, except that the context is reset after batches of inserts. More frequent resets don't seem to hurt performance, it may even help it a bit. Report and fix by Vinod Sridharan. Author: Vinod Sridharan <vsrid...@gmail.com> Reviewed-by: Tomas Vondra <to...@vondra.me> Discussion: https://postgr.es/m/CAFMdLD4p0VBd8JG=Nbi=bkv6rzfaigj_sxsfrw-2tnmnzfo...@mail.gmail.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/1681a70df3d68b6f9dc82645f97f8d4668edc42f Modified Files -------------- src/backend/access/gin/gininsert.c | 12 ++++++++++++ 1 file changed, 12 insertions(+)
