Re: pgsql: Fix minor problems with non-exclusive backup cleanup.

2020-08-06 Thread Tom Lane
Robert Haas writes: > On Thu, Aug 6, 2020 at 2:19 PM Tom Lane wrote: >> Also, while I'm bugging you: it wasn't quite clear from the thread >> whether this is alone sufficient to fix the user-visible issue >> reported by Bharath Rupireddy, or whether we still need to change >> the JIT logic as wel

Re: pgsql: Fix minor problems with non-exclusive backup cleanup.

2020-08-06 Thread Robert Haas
On Thu, Aug 6, 2020 at 2:19 PM Tom Lane wrote: > Robert Haas writes: > > Fix minor problems with non-exclusive backup cleanup. > > Seems like there's an extra space in this error message in > do_pg_abort_backup: > > + if (emit_warning) > + ereport(WARNING, > + (errmsg("abort

Re: pgsql: Fix minor problems with non-exclusive backup cleanup.

2020-08-06 Thread Tom Lane
Robert Haas writes: > Fix minor problems with non-exclusive backup cleanup. Seems like there's an extra space in this error message in do_pg_abort_backup: + if (emit_warning) + ereport(WARNING, + (errmsg("aborting backup due to backend exiting before pg_stop_back up was ca

pgsql: Fix minor problems with non-exclusive backup cleanup.

2020-08-06 Thread Robert Haas
Fix minor problems with non-exclusive backup cleanup. The previous coding imagined that it could call before_shmem_exit() when a non-exclusive backup began and then remove the previously-added handler by calling cancel_before_shmem_exit() when that backup ended. However, this only works provided t

pgsql: Fix minor problems with non-exclusive backup cleanup.

2020-08-06 Thread Robert Haas
Fix minor problems with non-exclusive backup cleanup. The previous coding imagined that it could call before_shmem_exit() when a non-exclusive backup began and then remove the previously-added handler by calling cancel_before_shmem_exit() when that backup ended. However, this only works provided t

pgsql: Fix minor problems with non-exclusive backup cleanup.

2019-12-19 Thread Robert Haas
Fix minor problems with non-exclusive backup cleanup. The previous coding imagined that it could call before_shmem_exit() when a non-exclusive backup began and then remove the previously-added handler by calling cancel_before_shmem_exit() when that backup ended. However, this only works provided t