Re: pgsql: Fix msvc builds for ActivePerl > 5.24

2018-03-04 Thread Magnus Hagander
On Sat, Mar 3, 2018 at 9:00 AM, Noah Misch wrote: > On Fri, Mar 02, 2018 at 11:42:32AM +, Magnus Hagander wrote: > > Fix msvc builds for ActivePerl > 5.24 > > > --- a/src/tools/msvc/Mkvcbuild.pm > > +++ b/src/tools/msvc/Mkvcbuild.pm > > @@ -524,9 +524,11 @@ sub mkvcbuild > > my

Re: pgsql: Fix msvc builds for ActivePerl > 5.24

2018-03-03 Thread Noah Misch
On Fri, Mar 02, 2018 at 11:42:32AM +, Magnus Hagander wrote: > Fix msvc builds for ActivePerl > 5.24 > --- a/src/tools/msvc/Mkvcbuild.pm > +++ b/src/tools/msvc/Mkvcbuild.pm > @@ -524,9 +524,11 @@ sub mkvcbuild > my $perl_path = $solution->{options}->{perl} . > '\lib\CORE\*perl*'

pgsql: Fix msvc builds for ActivePerl > 5.24

2018-03-02 Thread Magnus Hagander
Fix msvc builds for ActivePerl > 5.24 From this version ActivePerl ships both a .lib and a .a file for the perl library, which our code would detect as there being no library available. Instead, we should pick the .lib version and use that. Report and suggested fix in bug #15065 Author: Heath Lo