Peter Eisentraut writes:
> I have another question about this patch. The original issue was that
> it would trigger an Assert() inside pg_dump when some columns in
> pg_collation were null that were not expected. This patch now contains
> code like
> appendPQExpBufferStr(q, ", l
On 22.08.23 22:08, Jeff Davis wrote:
Fix pg_dump assertion failure when dumping pg_catalog.
Commit 396d348b04 did not account for the default collation.
Also, use pg_log_warning() instead of Assert().
Discussion:
https://postgr.es/m/ce071503fee88334aa70f360e6e4ea14d48305ee.camel%40j-davis.com
On 22.08.23 22:08, Jeff Davis wrote:
Fix pg_dump assertion failure when dumping pg_catalog.
Commit 396d348b04 did not account for the default collation.
Also, use pg_log_warning() instead of Assert().
Looking at this:
pg_log_warning("invalid collation \"%s\"", qcollname);
qcollname is a
Fix pg_dump assertion failure when dumping pg_catalog.
Commit 396d348b04 did not account for the default collation.
Also, use pg_log_warning() instead of Assert().
Discussion:
https://postgr.es/m/ce071503fee88334aa70f360e6e4ea14d48305ee.camel%40j-davis.com
Reviewed-by: Michael Paquier
Backpatch
Fix pg_dump assertion failure when dumping pg_catalog.
Commit 396d348b04 did not account for the default collation.
Also, use pg_log_warning() instead of Assert().
Discussion:
https://postgr.es/m/ce071503fee88334aa70f360e6e4ea14d48305ee.camel%40j-davis.com
Reviewed-by: Michael Paquier
Backpatch
Fix pg_dump assertion failure when dumping pg_catalog.
Commit 396d348b04 did not account for the default collation.
Also, use pg_log_warning() instead of Assert().
Discussion:
https://postgr.es/m/ce071503fee88334aa70f360e6e4ea14d48305ee.camel%40j-davis.com
Reviewed-by: Michael Paquier
Backpatch
