Re: pgsql: Fix race leading to incorrect conflict cause in InvalidatePossib

2024-04-11 Thread Michael Paquier
On Thu, Apr 11, 2024 at 12:38:06PM +0530, Bharath Rupireddy wrote: > I found a typo with the code added by this commit - we've used > XLogRecPtr/InvalidXLogRecPtr for xmins in place of > TransactionId/InvalidTransactionId. Attached a patch to fix this. Thanks for the report. Will fix. -- Michael

Re: pgsql: Fix race leading to incorrect conflict cause in InvalidatePossib

2024-04-11 Thread Bharath Rupireddy
On Tue, Feb 20, 2024 at 10:14 AM Michael Paquier wrote: > > Fix race leading to incorrect conflict cause in > InvalidatePossiblyObsoleteSlot() I found a typo with the code added by this commit - we've used XLogRecPtr/InvalidXLogRecPtr for xmins in place of TransactionId/InvalidTransactionId. Att

pgsql: Fix race leading to incorrect conflict cause in InvalidatePossib

2024-02-19 Thread Michael Paquier
Fix race leading to incorrect conflict cause in InvalidatePossiblyObsoleteSlot() The invalidation of an active slot is done in two steps: - Termination of the backend holding it, if any. - Report that the slot is obsolete, with a conflict cause depending on the slot's data. This can be racy becau

pgsql: Fix race leading to incorrect conflict cause in InvalidatePossib

2024-02-19 Thread Michael Paquier
Fix race leading to incorrect conflict cause in InvalidatePossiblyObsoleteSlot() The invalidation of an active slot is done in two steps: - Termination of the backend holding it, if any. - Report that the slot is obsolete, with a conflict cause depending on the slot's data. This can be racy becau