On 2022-Feb-14, Tomas Vondra wrote:
> On 2/14/22 14:36, Alvaro Herrera wrote:
> > I propose the attached comment additions instead.
>
> The comments seem fine to me (although not really related to these commits
> about sequence decoding).
Thanks, pushed.
--
Álvaro HerreraBreisgau, Deu
On 2/14/22 14:36, Alvaro Herrera wrote:
On 2022-Feb-13, Tomas Vondra wrote:
Fixing the tests however uncovered a bug in the code, because sequence
callbacks did not handle skip-empty-xacts properly. For trasactional
increments we need to check/update the xact_wrote_changes flag, and emit
the
On 2022-Feb-13, Tomas Vondra wrote:
> >> Fixing the tests however uncovered a bug in the code, because sequence
> >> callbacks did not handle skip-empty-xacts properly. For trasactional
> >> increments we need to check/update the xact_wrote_changes flag, and emit
> >> the BEGIN if it's the first c
On 2/13/22 16:26, Alvaro Herrera wrote:
> On 2022-Feb-12, Tomas Vondra wrote:
>
>> Fix skip-empty-xacts with sequences in test_decoding
>>
>> Regression tests need to use skip-empty-xacts = false, because there
>> might be accidental concurrent activity (like autovacuum), particularly
>> on slo
On 2022-Feb-12, Tomas Vondra wrote:
> Fix skip-empty-xacts with sequences in test_decoding
>
> Regression tests need to use skip-empty-xacts = false, because there
> might be accidental concurrent activity (like autovacuum), particularly
> on slow machines. The tests added by 80901b3291 failed to
Fix skip-empty-xacts with sequences in test_decoding
Regression tests need to use skip-empty-xacts = false, because there
might be accidental concurrent activity (like autovacuum), particularly
on slow machines. The tests added by 80901b3291 failed to do that in a
couple places, triggering occasio
