Re: pgsql: Fix timing issue in new subscription truncate test

2018-04-07 Thread Andres Freund
Hi, On 2018-04-07 13:31:53 -0400, Tom Lane wrote: > Oh ... digging into that, it's because that test depends on hstore, > which I hadn't installed. How much is that dependency really > buying us? There's some separate logic for non-core datatypes, so it seems good to test that. Hstore seems like

Re: pgsql: Fix timing issue in new subscription truncate test

2018-04-07 Thread Tom Lane
I wrote: > Testing the fix here, I just noticed that there's a pre-existing > problem in subscription/t/002_types.pl. It passes make check OK, > but make installcheck not so much. Investigating ... Oh ... digging into that, it's because that test depends on hstore, which I hadn't installed. How

Re: pgsql: Fix timing issue in new subscription truncate test

2018-04-07 Thread Tom Lane
Andres Freund writes: > On April 7, 2018 9:59:34 AM PDT, Peter Eisentraut wrote: >> We need to wait for the initial sync of all subscriptions. On >> some (faster?) machines, this didn't make a difference, but >> the (slower?) buildfarm machines are upset. > Failed on my very fast laptop fwiw.

Re: pgsql: Fix timing issue in new subscription truncate test

2018-04-07 Thread Andres Freund
On April 7, 2018 9:59:34 AM PDT, Peter Eisentraut wrote: >Fix timing issue in new subscription truncate test > >We need to wait for the initial sync of all subscriptions. On >some (faster?) machines, this didn't make a difference, but >the (slower?) buildfarm machines are upset. Failed on my v

pgsql: Fix timing issue in new subscription truncate test

2018-04-07 Thread Peter Eisentraut
Fix timing issue in new subscription truncate test We need to wait for the initial sync of all subscriptions. On some (faster?) machines, this didn't make a difference, but the (slower?) buildfarm machines are upset. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/