Harmonize parameter names in pg_dump/pg_dumpall. Make sure that function declarations use names that exactly match the corresponding names from function definitions in pg_dump/pg_dumpall related code.
Affected code happens to be inconsistent in how it applies conventions around how Archive and Archive Handle variables are named. Significant code churn is required to fully fix those inconsistencies, so take the least invasive approach possible: treat function definition names as authoritative, and mechanically adjust corresponding names from function definitions to match. Like other recent commits that cleaned up function parameter names, this commit was written with help from clang-tidy. Author: Peter Geoghegan <p...@bowt.ie> Reviewed-By: Tom Lane <t...@sss.pgh.pa.us> Discussion: https://postgr.es/m/cah2-wzmma+vzco6gr5nydz+sx0g14au-urzfutt2foraisv...@mail.gmail.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/20e69daa1348f6899fffe3c260bf44293551ee87 Modified Files -------------- src/bin/pg_dump/common.c | 2 +- src/bin/pg_dump/pg_backup.h | 14 +++++++------- src/bin/pg_dump/pg_backup_archiver.h | 2 +- src/bin/pg_dump/pg_backup_custom.c | 2 +- src/bin/pg_dump/pg_backup_directory.c | 2 +- src/bin/pg_dump/pg_backup_tar.c | 4 ++-- src/bin/pg_dump/pg_dump.c | 8 ++++---- src/bin/pg_dump/pg_dump.h | 6 +++--- src/bin/pg_dump/pg_dumpall.c | 6 ++++-- 9 files changed, 24 insertions(+), 22 deletions(-)