Re: pgsql: Improve PQtrace() output format

2021-04-05 Thread David Rowley
On Tue, 6 Apr 2021 at 17:21, Tom Lane wrote: > > I wrote: > > As best I can tell from these warnings, VS has the tv_sec field > > of struct timeval defined as something other than time_t. Because > > VS would never stoop to actually complying with the plain text of > > the POSIX standard. > > Ah,

Re: pgsql: Improve PQtrace() output format

2021-04-05 Thread Tom Lane
I wrote: > As best I can tell from these warnings, VS has the tv_sec field > of struct timeval defined as something other than time_t. Because > VS would never stoop to actually complying with the plain text of > the POSIX standard. Ah, seems like it's really Winsock's fault: https://docs.micros

Re: pgsql: Improve PQtrace() output format

2021-04-05 Thread Tom Lane
David Rowley writes: > I see the Visual Studio buildfarm members have been getting a compiler > warning since this commit [1] > (ClCompile target) -> > src/interfaces/libpq/fe-trace.c(87): warning C4133: 'function': > incompatible types - from 'long *' to 'const time_t *const ' > [C:\\pgbuildfar

Re: pgsql: Improve PQtrace() output format

2021-04-05 Thread David Rowley
On Wed, 31 Mar 2021 at 12:17, Alvaro Herrera wrote: > > Improve PQtrace() output format I see the Visual Studio buildfarm members have been getting a compiler warning since this commit [1] (ClCompile target) -> src/interfaces/libpq/fe-trace.c(87): warning C4133: 'function': incompatible types

pgsql: Improve PQtrace() output format

2021-03-30 Thread Alvaro Herrera
Improve PQtrace() output format Transform the PQtrace output format from its ancient (and mostly useless) byte-level output format to a logical-message-level output, making it much more usable. This implementation allows the printing code to be written (as it indeed was) by looking at the protoco